From owner-cvs-all Mon Feb 2 13:45:37 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA14366 for cvs-all-outgoing; Mon, 2 Feb 1998 13:45:37 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from panda.hilink.com.au (panda.hilink.com.au [203.8.15.25]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA14351; Mon, 2 Feb 1998 13:45:23 -0800 (PST) (envelope-from danny@panda.hilink.com.au) Received: (from danny@localhost) by panda.hilink.com.au (8.8.5/8.8.5) id IAA02858; Tue, 3 Feb 1998 08:44:30 +1100 (EST) Date: Tue, 3 Feb 1998 08:44:30 +1100 (EST) From: "Daniel O'Callaghan" To: Alex Nash cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sbin@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-To-Unsubscribe: mail to majordomo@FreeBSD.org "unsubscribe cvs-all" On Mon, 2 Feb 1998, Alex Nash wrote: > > Revision Changes Path > > 1.23.2.10 +7 -1 src/sbin/ipfw/ipfw.8 > > 1.34.2.11 +167 -93 src/sbin/ipfw/ipfw.c > ^^^^^^^^ > IIRC, this is considerably more than what was submitted :) Also, do we > really want to put such large changes into the 2.2 branch without any > testing in -current? The changes basically moved the getopt into a function and used a struct of option flags instead of discrete ints. The line count makes it look a lot bigger than it is. I also tidied some spacing and comments. I would have put it in -current last night, but the %lu -> %qu changes meant that hand merging is needed, and I was tired - better to do this with a fresh mind. Danny