From owner-svn-src-all@freebsd.org Wed Jul 20 13:33:42 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57D3CB9EA03 for ; Wed, 20 Jul 2016 13:33:42 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-qt0-x22f.google.com (mail-qt0-x22f.google.com [IPv6:2607:f8b0:400d:c0d::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 123A11D7B for ; Wed, 20 Jul 2016 13:33:42 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-qt0-x22f.google.com with SMTP id x25so26168672qtx.2 for ; Wed, 20 Jul 2016 06:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=bSHanfuZHo5kt9yK99Py9p4O/GZmY3Vboj49GoSqc7g=; b=Bwk3wGa5p2DVNZc2dus5CQur28SzB4EGbEDInirMo25nA4XGH/3H2Al+7Ko/P3Tunw LuFQ3uijw59COC7sJ6S54Rm5fZJ940I7Bph1Lo1VwdEp17cpujea9BBDR2ErH7tLs9sA qH26/LiUsToUzWaMNCNd70pU1SBG3X5dK8Xhs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=bSHanfuZHo5kt9yK99Py9p4O/GZmY3Vboj49GoSqc7g=; b=THJ3Mv0ss9n3+ZTNmw9gx7eQo5b7c8ppfrTmVvCpXc7JCVajD7guomsjG2dAPZu1du ik+YGdcPB9qbwiPcpEqLTdMrES5RioHsTeIql1Fm0mb6CtniyHQ+o5s0C8FE8+MTV7fF D6Tt/vjL+B8OzXUfTVxKoFoMhB1J/Kc1L387rlWpHVia5E4+gPn7Y+WVW01Y6u7ArnI8 ErfRKfnkL+pyyFWMMarwJHPE88LgN21T2LcDfgT5zevCkIBm5urllrBW0vyyaaA/EjxV nzJDNvy4tGIcGsDQ+3qWZUYksUch1gET63SH8HA6kT2ivj6VVibw/qG9GbTbrgVFq+/G IgYA== X-Gm-Message-State: ALyK8tIk4b/vRlZY4lbtfm3U5t8/2FilxM7JMwx4751T9pGu/uCIWyT5hsBSczhgNQtih7lc X-Received: by 10.237.53.19 with SMTP id a19mr68514536qte.67.1469021621035; Wed, 20 Jul 2016 06:33:41 -0700 (PDT) Received: from [100.127.85.21] ([69.53.246.16]) by smtp.gmail.com with ESMTPSA id o70sm1418645qka.29.2016.07.20.06.33.39 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Jul 2016 06:33:40 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r303037 - head/sys/kern From: Randall Stewart In-Reply-To: <20160720065335.GU1076@FreeBSD.org> Date: Wed, 20 Jul 2016 15:33:37 +0200 Cc: Randall Ray Stewart , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <1CA02E0F-6871-4291-9F5A-20EFF5F6315D@netflix.com> References: <201607191831.u6JIVJWq007542@repo.freebsd.org> <20160720065335.GU1076@FreeBSD.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2016 13:33:42 -0000 Gleb I wish you would have responded earlier.. I am more than glad to hand off all kern_timeout.c to you=E2=80=A6 please take it commit what you = want to it and have it. I hate the code and I dislike having to touch it. Its yours.. I can assure you I will not touch it again. R > On Jul 20, 2016, at 8:53 AM, Gleb Smirnoff = wrote: >=20 > On Tue, Jul 19, 2016 at 06:31:19PM +0000, Randall Stewart wrote: > R> Author: rrs > R> Date: Tue Jul 19 18:31:19 2016 > R> New Revision: 303037 > R> URL: https://svnweb.freebsd.org/changeset/base/303037 > R>=20 > R> Log: > R> This reverts out Gleb's changes and adds three small > R> fixes that I think closes up the races Gleb was > R> looking for. This is running quite nicely in Netflix and > R> now no longer causes TCP-tcb leaks. > R> =20 > R> Differential Revision: 7135 >=20 > Just to notice that I am completely pissed of by this commit > war, that you started. >=20 > I've been testing my changes properly, I gave people time to > review my changes. You didn't. >=20 > =46rom your explanation in other emails I see that you've been > testing your changes with a version of FreeBSD that is a heavily > modified FreeBSD 10, not 11. >=20 > The new code you mixed with revert of mine, doesn't fix the > problem observed. It fixes another problem that you imagined, > which might exist, but isn't observed. We already discussed that > and you didn't prove it wrong. >=20 > Your change doesn't even revert my change completely. >=20 > --=20 > Totus tuus, Glebius. -------- Randall Stewart rrs@netflix.com 803-317-4952