From owner-freebsd-stable@FreeBSD.ORG Fri Feb 19 15:29:40 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A81E4106568D; Fri, 19 Feb 2010 15:29:40 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 3C0538FC08; Fri, 19 Feb 2010 15:29:39 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o1JFT3Yk037152 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 19 Feb 2010 17:29:03 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id o1JFT3xs057734; Fri, 19 Feb 2010 17:29:03 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id o1JFT2kt057733; Fri, 19 Feb 2010 17:29:02 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 19 Feb 2010 17:29:02 +0200 From: Kostik Belousov To: Rick Macklem Message-ID: <20100219152902.GZ50403@deviant.kiev.zoral.com.ua> References: <4B7D74A7.6010006@acm.poly.edu> <4B7D9C5C.1090909@acm.poly.edu> <20100218220714.GU50403@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TXv8ADjWKuT9E31y" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: marius@freebsd.org, Boris Kochergin , FreeBSD-STABLE Mailing List Subject: Re: Can't load NFS server module with a custom 8.0 kernel X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2010 15:29:40 -0000 --TXv8ADjWKuT9E31y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 19, 2010 at 10:21:37AM -0500, Rick Macklem wrote: >=20 >=20 > On Fri, 19 Feb 2010, Kostik Belousov wrote: >=20 > [stuff snipped] > > > >I think this is changed in HEAD, and part of the changes are already in > >stable/8, which is different from 8.0 too. > > > >Anyway, for HEAD nfsserver we need 1. nfscommon 2. nfs_common. Also, > >nfs_common module is not attached to the build. > > > >The patch below gives up on nfs_common, puts that parts into nfscommon, > >and corrects dependencies for nfsserver and nfsclient. With the patch, > >I can export and mount nfs filesystem on the HEAD again, with all > >nfs* stuff loaded as modules. If following this route,=20 > >sys/modules/nfs_common > >can be removed. > > > >I did not looked into fs/nfs* modules. > > > The common module for fs/nfs* is called nfscommon, which was why Marius > used nfs_common. I don't know what happens when you have two modules of > the same name. I suspect your fix is fine otherwise, since the=20 I do not introduce new module, I added symbols from nfs_common to nfscommon, indending to remove sys/modules/nfs_common from src, since it is not attached to the build even without the patch. It seems that there is no name conflicts between newnfs symbols from this combined module and old nfs server and client. I did not checked possible name conflicts between this nfscommon and fs/nfs*, that is what I mean by "not looked into ...". > experimental stuff (fs/nfs*) won't get loaded unless "-e" is used on > mountd/nfsd. >=20 > Thanks for the help with this, rick --TXv8ADjWKuT9E31y Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkt+rj4ACgkQC3+MBN1Mb4jZQgCeMr8piSoUSyucnrSr0RtGTa5F YNgAoKtYOh7oyeJsKlZwa3r5LOGQMsEY =W/+e -----END PGP SIGNATURE----- --TXv8ADjWKuT9E31y--