Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 04 Dec 2012 23:58:58 -0800
From:      Cy Schubert <Cy.Schubert@komquats.com>
To:        gahr@FreeBSD.org
Cc:        svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org, Cy Schubert <cy@FreeBSD.org>
Subject:   Re: svn commit: r308201 - head/mail/exmh2
Message-ID:  <201212050758.qB57wwjg005243@slippy.cwsent.com>
In-Reply-To: Message from Pietro Cerutti <gahr@FreeBSD.org> of "Tue, 04 Dec 2012 12:41:11 %2B0100." <20121204114110.GC5906@gahrfit.gahr.ch>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20121204114110.GC5906@gahrfit.gahr.ch>, Pietro Cerutti writes:
> 
> --1SQmhf2mF2YjsYvc
> Content-Type: text/plain; charset=utf-8
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
> 
> On 2012-Dec-04, 06:21, Cy Schubert wrote:
> > Author: cy
> > Date: Tue Dec  4 06:21:05 2012
> > New Revision: 308201
> > URL: http://svnweb.freebsd.org/changeset/ports/308201
> >=20
> > Log:
> >   Use TCL/Tk 8.6. This fixes issues with the mail messages list "More..."
> >   button.
> >  =20
> >   Assume care and feeding of this port.
> >  =20
> >   Feature safe:	yes
> >=20
> > Modified:
> >   head/mail/exmh2/Makefile
> >=20
> > Modified: head/mail/exmh2/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D
> > --- head/mail/exmh2/Makefile	Tue Dec  4 06:18:16 2012	(r30820
> 0)
> > +++ head/mail/exmh2/Makefile	Tue Dec  4 06:21:05 2012	(r30820
> 1)
> > @@ -14,7 +14,7 @@ CATEGORIES+=3D	mail tk
> >  MASTER_SITES=3D	${MASTER_SITE_TCLTK} \
> >  		SF
> > =20
> > -MAINTAINER?=3D	ports@FreeBSD.org
> > +MAINTAINER?=3D	cy@FreeBSD.org
> >  COMMENT?=3D	X11/TK based mail reader front end to MH
> > =20
> >  .if defined(JAPANESE_EXMH)
> > @@ -23,10 +23,10 @@ BUILD_DEPENDS=3D	tclsh8.0jp:${PORTSDIR}/ja
> >  WISH=3D		wish8.0jp
> >  TCLSH=3D		tclsh8.0jp
> >  .else
> > -RUN_DEPENDS=3D	wish8.5:${PORTSDIR}/x11-toolkits/tk85
> > -BUILD_DEPENDS=3D	tclsh8.5:${PORTSDIR}/lang/tcl85
> > -WISH=3D		wish8.5
> > -TCLSH=3D		tclsh8.5
> > +RUN_DEPENDS=3D	wish8.6:${PORTSDIR}/x11-toolkits/tk86
> > +BUILD_DEPENDS=3D	tclsh8.6:${PORTSDIR}/lang/tcl86
> > +WISH=3D		wish8.6
> > +TCLSH=3D		tclsh8.6
> >  .endif
> 
> Might I suggest the following patch here?
> 
> =3D=3D BEGIN PATCH =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D
> Index: Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- Makefile	(revision 308234)
> +++ Makefile	(working copy)
> @@ -23,10 +23,7 @@
>  WISH=3D		wish8.0jp
>  TCLSH=3D		tclsh8.0jp
>  .else
> -RUN_DEPENDS=3D	wish8.6:${PORTSDIR}/x11-toolkits/tk86
> -BUILD_DEPENDS=3D	tclsh8.6:${PORTSDIR}/lang/tcl86
> -WISH=3D		wish8.6
> -TCLSH=3D		tclsh8.6
> +USE_TK=3D		86
>  .endif
> =20
>  # exmh is pretty useless without this, but it's not needed to build it.
> @@ -55,7 +52,7 @@
> =20
>  do-build:
>  	@cd ${WRKSRC} && ${SETENV} PREFIX=3D${PREFIX} TCLSH=3D${TCLSH} \
> -		WISH=3D${PREFIX}/bin/${WISH} WRKSRC=3D${WRKSRC} \
> +		WISH=3D${WISH} WRKSRC=3D${WRKSRC} \
>  		${SCRIPTS_ENV} ${SH} ${SCRIPTDIR}/build
> =20
>  do-install:
> =3D=3D END PATCH =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> 
> Moreover, I've seen that 2.8.0 is out. It's buildable as long as you
> 
> D       files/patch-lib-folder.tcl
> D       files/patch-lib-quote.tcl
> D       files/patch-lib-uri.tcl
> 
> Unfortunately I'm not familiar enough with the interface to properly
> run-test it.

Cool, thanks. I'll commit the first suggestion as soon as I get a chance. 
And, I'll look into 2.8.0 when I get some free time.


-- 
Cheers,
Cy Schubert <Cy.Schubert@komquats.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201212050758.qB57wwjg005243>