From owner-cvs-all@FreeBSD.ORG Sun Oct 8 10:39:59 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 42EFA16A403; Sun, 8 Oct 2006 10:39:59 +0000 (UTC) (envelope-from erwin@mail.droso.net) Received: from mail.droso.net (koala.droso.net [193.88.12.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF88343D5E; Sun, 8 Oct 2006 10:39:58 +0000 (GMT) (envelope-from erwin@mail.droso.net) Received: by mail.droso.net (Postfix, from userid 1001) id BAF0422BDC; Sun, 8 Oct 2006 12:39:57 +0200 (CEST) Date: Sun, 8 Oct 2006 12:39:57 +0200 From: Erwin Lansing To: Alexander Botero-Lowry Message-ID: <20061008103957.GU10626@droso.net> Mail-Followup-To: Alexander Botero-Lowry , Pav Lucistnik , ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, alex@Laptop.mine.box References: <200610072356.k97NuAW4051992@repoman.freebsd.org> <20061008084005.GM10626@droso.net> <200610080849.k988ndp6086544@Laptop.mine.box> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zAIN9dnKNiFxaW1E" Content-Disposition: inline In-Reply-To: <200610080849.k988ndp6086544@Laptop.mine.box> X-Operating-System: FreeBSD/i386 5.4-RELEASE User-Agent: Mutt/1.5.13 (2006-08-11) Cc: cvs-ports@FreeBSD.org, Pav Lucistnik , alex@Laptop.mine.box, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/science/py-scipy Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Oct 2006 10:39:59 -0000 --zAIN9dnKNiFxaW1E Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 08, 2006 at 01:49:39AM -0700, Alexander Botero-Lowry wrote: > >=20 > > On Sat, Oct 07, 2006 at 11:56:10PM +0000, Pav Lucistnik wrote: > > > pav 2006-10-07 23:56:10 UTC > > >=3D20 > > > FreeBSD ports repository > > >=3D20 > > > Modified files: > > > science/py-scipy Makefile=3D20 > > > Log: > > > - Fix OPTIONS > > > =3D20 > > > | DISTNAME=3D3D SciPy_complete-${PORTVERSION} > > > | +LATEST_LINK=3D3D py-${PORTNAME} > > > | =3D20 > >=20 > > How does setting LATEST_LINK fix OPTIONS? > >=20 > With ports that include a PKGNAME_PREFIX it is required. Otherwise you get > an error like: >=20 > If you attempt to run make config for a port with ${PKGNAMEPREFIX} define= d, the make config process will error out with: > =3D=3D=3D> Using wrong configuration file /path/options/file > The solution is to define LATEST_LINK to be prefix-${PORTNAME}, but this = should be done internally. >=20 > The problem is because ${_OPTIONFILE} is staticially defined (by using ec= ho),=20 > before the various bsd.*.mk files that set the appropriate PKGNAME_PREFIX= s=20 > like PYTHON_PKGNAMEPREFIX. So part of the options bit is looking for a fi= le > with the prefix and part is looking for a packagename without it, and it > gets itself quite upset. >=20 > I have a more detailed and accurate explanation of this problem in an ema= il > somewhere, I will try and find it. (I submitted a PR where LATEST_LINK was > set and the committer removed it and broke the port, so I went and docume= nted > the problem.) >=20 Thank you for the explanation. The commit log was just confusing compared to the diff. Cheers, -erwin --=20 Erwin Lansing http://droso.org Security is like an onion. (o_ _o) It's made up of several layers \\\_\ /_/// erwin@FreeBSD.org And it makes you cry. <____) (____> erwin@aauug.dk --zAIN9dnKNiFxaW1E Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFKNV9qy9aWxUlaZARAlnmAJ9rMtJ4N+UeXPMMMrVIAps8DDT5bwCffUYU zj5xKWXFXgM0seC4ypcRjyU= =oLxC -----END PGP SIGNATURE----- --zAIN9dnKNiFxaW1E--