Date: Wed, 02 Mar 2005 08:57:57 -0700 From: Scott Long <scottl@samsco.org> To: Scott Long <scottl@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/esp esp_sbus.c ncr53c9x.c Message-ID: <4225E285.5000605@samsco.org> In-Reply-To: <200503021556.j22FugDk081853@repoman.freebsd.org> References: <200503021556.j22FugDk081853@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Scott Long wrote: > scottl 2005-03-02 15:56:42 UTC > > FreeBSD src repository > > Modified files: > sys/dev/esp esp_sbus.c ncr53c9x.c > Log: > The existing locking in the esp driver appears to be fairly adequate, so > set the interrupt handler to be INTR_MPSAFE now that xpt_done() can be > called without Giant. Giant is still on the top half of the driver and > the timeout handlers. > > Revision Changes Path > 1.9 +1 -1 src/sys/dev/esp/esp_sbus.c > 1.8 +0 -2 src/sys/dev/esp/ncr53c9x.c My Ultra2 now has no [GIANT-LOCKED] messages at all during boot and seems to run without any problems. I haven't done any performance measurements yet, and enabling mpsafevfs will probably negate most improvements that this might have given, but it's a start. David O'brien: THIS IS NOT A FREEBSD 5.4 CANDIDATE. It's a shame that I'll need to postfix all of my commits from now on with this message. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4225E285.5000605>