From owner-svn-src-all@FreeBSD.ORG  Mon Nov 14 08:01:23 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C7030106566B;
	Mon, 14 Nov 2011 08:01:23 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net
	[IPv6:2001:7b8:2ff:146::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 860C18FC12;
	Mon, 14 Nov 2011 08:01:23 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:d8ac:9806:a63d:a8d4] (unknown
	[IPv6:2001:7b8:3a7:0:d8ac:9806:a63d:a8d4])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by tensor.andric.com (Postfix) with ESMTPSA id AD8D95C59;
	Mon, 14 Nov 2011 09:01:22 +0100 (CET)
Message-ID: <4EC0CAD0.1070100@FreeBSD.org>
Date: Mon, 14 Nov 2011 09:01:20 +0100
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:8.0) Gecko/20111105 Thunderbird/8.0
MIME-Version: 1.0
To: Peter Jeremy <peterjeremy@acm.org>
References: <201111122016.pACKG7sr059722@svn.freebsd.org>
	<20111114053116.GA91295@server.vk2pj.dyndns.org>
In-Reply-To: <20111114053116.GA91295@server.vk2pj.dyndns.org>
X-Enigmail-Version: 1.3.3
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, David Chisnall <theraven@FreeBSD.org>
Subject: Re: svn commit: r227474 - head/sys/amd64/include
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Nov 2011 08:01:23 -0000

On 2011-11-14 06:31, Peter Jeremy wrote:
> On 2011-Nov-12 20:16:07 +0000, David Chisnall <theraven@FreeBSD.org> wrote:
...
>> +#define	SIG_ATOMIC_MIN	LONG_MIN
>> +#define	SIG_ATOMIC_MAX	LONG_MAX
> 
> 2) As far as I can see, all other defines in _stdint.h, across all
> architectures, have explicit lengths, so I believe this would be
> better specified as:
> 
> #define	SIG_ATOMIC_MIN	INT64_MIN
> #define	SIG_ATOMIC_MAX	INT64_MAX

Why?  On amd64, sig_atomic_t is defined as long, so LONG_MIN and
LONG_MAX are more logical.  In fact, for all architectures, sig_atomic_t
is either int or long, so INTnn_MIN/MAX is rather strangely chosen.