Date: Sat, 24 Aug 2019 11:50:18 -0700 From: Conrad Meyer <cem@freebsd.org> To: Eugene Grosbein <eugen@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r351459 - head/usr.bin/last Message-ID: <CAG6CVpUurYk9Nt05hpG634Kz_MszNARe%2BM7ShfoGmhd3yaQ_eA@mail.gmail.com> In-Reply-To: <201908241550.x7OFoD80037926@repo.freebsd.org> References: <201908241550.x7OFoD80037926@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Eugene, This change introduced some style(9) violations. On Sat, Aug 24, 2019 at 8:50 AM Eugene Grosbein <eugen@freebsd.org> wrote: > > Author: eugen > Date: Sat Aug 24 15:50:13 2019 > New Revision: 351459 > URL: https://svnweb.freebsd.org/changeset/base/351459 > ... > --- head/usr.bin/last/last.c Sat Aug 24 15:38:07 2019 (r351458) > +++ head/usr.bin/last/last.c Sat Aug 24 15:50:13 2019 (r351459) > ... > @@ -158,7 +158,9 @@ main(int argc, char *argv[]) > d_first = (*nl_langinfo(D_MD_ORDER) == 'd'); > > (void) setlocale(LC_CTYPE, ""); > - utf8flag = (strcmp(nl_langinfo(CODESET), "UTF-8") == 0); > + p = nl_langinfo(CODESET); > + if (strcmp (p, "UTF-8") == 0 || strcmp (p, "US-ASCII") == 0) > + noctfix = 1; There are extraneous spaces between strcmp and '('. Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpUurYk9Nt05hpG634Kz_MszNARe%2BM7ShfoGmhd3yaQ_eA>