From owner-cvs-all@FreeBSD.ORG Sun May 2 10:32:36 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 23CE616A4CF; Sun, 2 May 2004 10:32:36 -0700 (PDT) Received: from meitner.wh.uni-dortmund.de (meitner.wh.uni-dortmund.de [129.217.129.133]) by mx1.FreeBSD.org (Postfix) with ESMTP id A0FDB43D39; Sun, 2 May 2004 10:32:35 -0700 (PDT) (envelope-from michaelnottebrock@gmx.net) Received: from lofi.dyndns.org (pc2-105.intern.meitner [10.3.12.105]) by meitner.wh.uni-dortmund.de (Postfix) with ESMTP id B5C0E16758A; Sun, 2 May 2004 19:32:34 +0200 (CEST) Received: from [192.168.8.4] (kiste.my.domain [192.168.8.4]) (authenticated bits=0) by lofi.dyndns.org (8.12.10/8.12.10) with ESMTP id i42HWYGK039721 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Sun, 2 May 2004 19:32:34 +0200 (CEST) (envelope-from michaelnottebrock@gmx.net) From: Michael Nottebrock To: obrien@freebsd.org Date: Sun, 2 May 2004 19:32:29 +0200 User-Agent: KMail/1.6.2 References: <200405021310.i42DAoZM055616@repoman.freebsd.org> <20040502171345.GA20168@dragon.nuxi.com> In-Reply-To: <20040502171345.GA20168@dragon.nuxi.com> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Boundary-02=_xCTlAHOyjC0K3L1"; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200405021932.33696.michaelnottebrock@gmx.net> X-Virus-Scanned: by amavisd-new cc: cvs-ports@freebsd.org cc: cvs-all@freebsd.org cc: ports-committers@freebsd.org Subject: Re: cvs commit: ports/x11/kdebase3 Makefile pkg-message ports/x11/kdebase3/files pkg-message X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 May 2004 17:32:36 -0000 --Boundary-02=_xCTlAHOyjC0K3L1 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday 02 May 2004 19:13, David O'Brien wrote: > On Sun, May 02, 2004 at 06:10:50AM -0700, Michael Nottebrock wrote: > > lofi 2004/05/02 06:10:50 PDT > > > > FreeBSD ports repository > > > > Modified files: > > x11/kdebase3 Makefile > > Added files: > > x11/kdebase3/files pkg-message > > Removed files: > > x11/kdebase3 pkg-message > > Log: > > Process the pkg-message template earlier than post-install so > > package users will actually get to see it the right way. > > > > PR: ports/66123 > > Reported by: obrien > > Thank you for fixing this, but why didn't you just leave pkg-message > where it was? Just because it needs fixing up it doesn't have to live in > the non-standard files/ directory. Please consider moving that and the > plists back to the main kdebase3 directory. I don't think a pkg-message that really isn't one but a template that needs= to=20 be processed first should be visible, so I'd rather hide it in ${FILESDIR}.= =20 Perhaps I should have renamed it to message-template? Also, our plist bits= =20 aren't standard plists (the real plist is concatenated from them, depending= =20 on build options) and thus don't belong into the portdir, but into=20 ${FILESDIR}. =2D-=20 ,_, | Michael Nottebrock | lofi@freebsd.org (/^ ^\) | FreeBSD - The Power to Serve | http://www.freebsd.org \u/ | K Desktop Environment on FreeBSD | http://freebsd.kde.org --Boundary-02=_xCTlAHOyjC0K3L1 Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAlTCxXhc68WspdLARAvHwAJ46T3qtBrMm1qcLb9iZxnYWRH6N5ACeLP+Z vv+RGBn+xZZoqyUNkT+vEGc= =tXCe -----END PGP SIGNATURE----- --Boundary-02=_xCTlAHOyjC0K3L1--