From owner-svn-src-head@FreeBSD.ORG Sun Nov 11 19:49:50 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9472192D; Sun, 11 Nov 2012 19:49:50 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id EF94B8FC13; Sun, 11 Nov 2012 19:49:49 +0000 (UTC) Received: from tom.home (localhost [127.0.0.1]) by kib.kiev.ua (8.14.5/8.14.5) with ESMTP id qABJnfMA004343; Sun, 11 Nov 2012 21:49:41 +0200 (EET) (envelope-from kostikbel@gmail.com) X-DKIM: OpenDKIM Filter v2.5.2 kib.kiev.ua qABJnfMA004343 Received: (from kostik@localhost) by tom.home (8.14.5/8.14.5/Submit) id qABJnft3004342; Sun, 11 Nov 2012 21:49:41 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 11 Nov 2012 21:49:41 +0200 From: Konstantin Belousov To: Roman Divacky Subject: Re: svn commit: r242889 - head/sys/dev/xen/netback Message-ID: <20121111194941.GW73505@kib.kiev.ua> References: <201211111042.qABAgYk4066339@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HECHSKL9QsOKTVdc" Content-Disposition: inline In-Reply-To: <201211111042.qABAgYk4066339@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=0.2 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Nov 2012 19:49:50 -0000 --HECHSKL9QsOKTVdc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 11, 2012 at 10:42:34AM +0000, Roman Divacky wrote: > Author: rdivacky > Date: Sun Nov 11 10:42:34 2012 > New Revision: 242889 > URL: http://svnweb.freebsd.org/changeset/base/242889 >=20 > Log: > Change the XNB_ASSERT from a statement expression to do-while(0) as its > result is never used. >=20 > Modified: > head/sys/dev/xen/netback/netback_unit_tests.c >=20 > Modified: head/sys/dev/xen/netback/netback_unit_tests.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/xen/netback/netback_unit_tests.c Sun Nov 11 08:22:58 201= 2 (r242888) > +++ head/sys/dev/xen/netback/netback_unit_tests.c Sun Nov 11 10:42:34 201= 2 (r242889) > @@ -62,7 +62,7 @@ __FBSDID("$FreeBSD$"); > * iff the assertion failed. Note the implied parameters buffer and > * buflen > */ > -#define XNB_ASSERT(cond) ({ \ > +#define XNB_ASSERT(cond) do ( \ > int passed =3D (cond); \ > char *_buffer =3D (buffer); \ > size_t _buflen =3D (buflen); \ > @@ -71,7 +71,7 @@ __FBSDID("$FreeBSD$"); > strlcat(_buffer, ":" TOSTRING(__LINE__) \ > " Assertion Error: " #cond "\n", _buflen); \ > } \ > - ! passed; }) > + } while (0) > =20 > =20 > /** Look at r240747. --HECHSKL9QsOKTVdc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCgAVUACgkQC3+MBN1Mb4hXIgCgy/cm8gA3aLndTR4xEFwvyGio HH0AoJDMvFelLECsRPhc99UFXoorRTNI =xJNq -----END PGP SIGNATURE----- --HECHSKL9QsOKTVdc--