From owner-freebsd-net@freebsd.org Mon Sep 11 17:25:05 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5414FE1807B for ; Mon, 11 Sep 2017 17:25:05 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-yw0-f171.google.com (mail-yw0-f171.google.com [209.85.161.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1914E69CB4; Mon, 11 Sep 2017 17:25:04 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-yw0-f171.google.com with SMTP id s62so23044175ywg.0; Mon, 11 Sep 2017 10:25:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=20UY3VEH8sQwlyD+Ift4FNlWZyBiHIomMOLsMebKJ04=; b=CfR2ZRkT1L6vidmpnTHzuFGbhbcBQTwEgrLTIuPAU3yNqGME1RPYouJ0ZUYbzHWK5D JXZBt086QbUIGGe0mJSEX9NV4d9kM9GNil0ax9rrmonRExltW5Q+w56Ayg7M3YeLjnEX z4iqCypihXvz3IEQ7mMEKaAg7DD53uokPpN2qEHU8UfEprVHvaj/oP2cBMC963GgB4Mt AefO2Gmr2NLpnlM69CqXc1kgdMPvLWZF9CFJ2HoqaKTJL4bhcXbSdoKXeREq7xYKeLic j317v6WN10ENYFXpqxDH/wNEX86Hqjeyejd25mgJzejJ74WRWZ6Z0aJuoVRqT5mgOUnE qsdQ== X-Gm-Message-State: AHPjjUiptZd7TirMKpXOS2ikz7WzUmKBhw3LFCJEKPVQJc/LqAiM2+qk 4C7zXKNo86IRKcHeBneRZA== X-Received: by 10.37.35.147 with SMTP id j141mr10207322ybj.214.1505150316745; Mon, 11 Sep 2017 10:18:36 -0700 (PDT) Received: from mail-io0-f181.google.com (mail-io0-f181.google.com. [209.85.223.181]) by smtp.gmail.com with ESMTPSA id h186sm3262937ywh.52.2017.09.11.10.18.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Sep 2017 10:18:35 -0700 (PDT) Received: by mail-io0-f181.google.com with SMTP id n69so29564496ioi.5; Mon, 11 Sep 2017 10:18:35 -0700 (PDT) X-Google-Smtp-Source: AOwi7QDgQ1h4tbzgytxQSlgY+5mly05tgn+VzS95xT5BzMWFMhzkJabIIYSXO8smtU4OKBEbzUj3+MkonHHImpgpqYM= X-Received: by 10.202.78.205 with SMTP id c196mr7374403oib.183.1505150315325; Mon, 11 Sep 2017 10:18:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eric Joyner Date: Mon, 11 Sep 2017 17:18:24 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: ixl(4) RSS hash type To: Sepherosa Ziehau , "freebsd-net@freebsd.org" , Sean Bruno , Robert Watson , Adrian Chadd , Andrew Gallatin Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 17:25:05 -0000 I think that sounds right; but Adrian is the one who put the code in the #ifdef RSS blocks in. We don't have it enabled/defined in our testing here. - Eric On Sun, Sep 10, 2017 at 8:01 PM Sepherosa Ziehau wrote: > Hi all, > > I am on the way to cleanup the UDP_IPV4_EX bit. The only effective > consumer of this undefined RSS hash type is ixl. > > So I took a bit close look at it, then I have several question about > its hash type configuration: > > ixl_set_rss_pctypes(). It tries to set hash for IPV6 fragment, if > RSS_IPV6_EX is set for "options RSS". RSS_IPV6_EX never meant IPV6 > fragments: > > https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types#ndishashipv6ex > > ixl_ptype_to_hash(). As far as I understand, the decoded.outer_frag > means "outer packet header indicates a fragment", which has nothing to > do with the any of the IPV6_EX related bits: > > https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types > > I believe these all should be fixed. > > Thanks, > sephe > > -- > Tomorrow Will Never Die >