Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 Mar 2010 06:56:17 +0000 (UTC)
From:      Fabien Thomas <fabient@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org
Subject:   svn commit: r205824 - stable/7/sys/dev/hwpmc
Message-ID:  <201003290656.o2T6uH3r077646@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: fabient
Date: Mon Mar 29 06:56:17 2010
New Revision: 205824
URL: http://svn.freebsd.org/changeset/base/205824

Log:
  MFC r205694:
  Handling SIGPIPE will cause deadlock/crash.
  Return an error immediatly in case of hard shutdown.

Modified:
  stable/7/sys/dev/hwpmc/hwpmc_logging.c
Directory Properties:
  stable/7/sys/   (props changed)
  stable/7/sys/cddl/contrib/opensolaris/   (props changed)
  stable/7/sys/contrib/dev/acpica/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)

Modified: stable/7/sys/dev/hwpmc/hwpmc_logging.c
==============================================================================
--- stable/7/sys/dev/hwpmc/hwpmc_logging.c	Mon Mar 29 06:55:38 2010	(r205823)
+++ stable/7/sys/dev/hwpmc/hwpmc_logging.c	Mon Mar 29 06:56:17 2010	(r205824)
@@ -298,7 +298,6 @@ pmclog_loop(void *arg)
 
 		mtx_unlock(&pmc_kthread_mtx);
 
-sigpipe_retry:
 		/* process the request */
 		PMCDBG(LOG,WRI,2, "po=%p base=%p ptr=%p", po,
 		    lb->plb_base, lb->plb_ptr);
@@ -322,9 +321,6 @@ sigpipe_retry:
 
 		if (error) {
 			/* XXX some errors are recoverable */
-			if (error == EPIPE)
-				goto sigpipe_retry;
-
 			/* send a SIGIO to the owner and exit */
 			PROC_LOCK(p);
 			psignal(p, SIGIO);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003290656.o2T6uH3r077646>