From owner-freebsd-hackers@FreeBSD.ORG Thu Sep 4 15:49:04 2008 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 931301065674; Thu, 4 Sep 2008 15:49:04 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp3-g19.free.fr (smtp3-g19.free.fr [212.27.42.29]) by mx1.freebsd.org (Postfix) with ESMTP id 231368FC08; Thu, 4 Sep 2008 15:49:04 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp3-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp3-g19.free.fr (Postfix) with ESMTP id 08C3B17B5D9; Thu, 4 Sep 2008 17:49:03 +0200 (CEST) Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98]) by smtp3-g19.free.fr (Postfix) with ESMTP id BABAA17B536; Thu, 4 Sep 2008 17:49:02 +0200 (CEST) Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25]) by tatooine.tataz.chchile.org (Postfix) with ESMTP id 817529B497; Thu, 4 Sep 2008 15:41:38 +0000 (UTC) Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000) id 7CC3F4089; Thu, 4 Sep 2008 17:41:38 +0200 (CEST) Date: Thu, 4 Sep 2008 17:41:38 +0200 From: Jeremie Le Hen To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Message-ID: <20080904154138.GM72107@obiwan.tataz.chchile.org> References: <20080904124653.GK72107@obiwan.tataz.chchile.org> <20080904135200.GC31289@alpha.local> <86ljy857zz.fsf@ds4.des.no> <20080904141705.GL72107@obiwan.tataz.chchile.org> <86hc8w55mr.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86hc8w55mr.fsf@ds4.des.no> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: freebsd-hackers@FreeBSD.org, Rui Paulo Subject: Re: Creation of the NO_SSP build knob X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Sep 2008 15:49:04 -0000 On Thu, Sep 04, 2008 at 04:48:28PM +0200, Dag-Erling Smørgrav wrote: > bsd.own.mk: > > 184 # > 185 # Supported NO_* options (if defined, MK_* will be forced to "no", > 186 # regardless of user's setting). > 187 # > 188 .for var in \ > 189 INSTALLLIB \ > 190 MAN \ > 191 PROFILE > 192 .if defined(NO_${var}) > 193 WITHOUT_${var}= > 194 .endif > 195 .endfor Ok, thank you Dag-Erling. I didn't understand what you meant the first time. If SSP belongs to this list, then NO_SSP is an alias for WITHOUT_SSP. But it will still not be possible to use WITH_SSP in src.conf or command-line. Does this mean that enforcing the default values with knobs is not supported? Or put differently, is it forbidden to use the opposite knobs of those documented in src.conf(5)? bsd.own.mk has the following test: 361 .if defined(WITH_${var}) && defined(WITHOUT_${var}) 362 .error WITH_${var} and WITHOUT_${var} can't both be set. 363 .endif So I would say that it is allowed to use WITH_SSP, even if it's the default. This can be a problem. Let's say a user has WITH_INFO= in src.conf for some reason. If WITHOUT_INFO= is used somewhere in the source tree, it will break with an error misleading for the user: WITH_INFO and WITHOUT_INFO can't be both set. Shouldn't we have a knob that overrides whatever the user says, only for internal use in the source tree? That was my original intent when asking if I could add NO_SSP. Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org >