From owner-cvs-all  Sat Sep 25 10:25: 9 1999
Delivered-To: cvs-all@freebsd.org
Received: from vader.cs.berkeley.edu (vader.CS.Berkeley.EDU [128.32.38.234])
	by hub.freebsd.org (Postfix) with ESMTP
	id 557C414CEC; Sat, 25 Sep 1999 10:25:07 -0700 (PDT)
	(envelope-from asami@stampede.cs.berkeley.edu)
Received: from silvia.hip.berkeley.edu (sji-ca2-74.ix.netcom.com [205.186.212.74])
	by vader.cs.berkeley.edu (8.9.3/8.9.3) with ESMTP id KAA11239;
	Sat, 25 Sep 1999 10:23:55 -0700 (PDT)
	(envelope-from asami@stampede.cs.berkeley.edu)
Received: (from asami@localhost) by silvia.hip.berkeley.edu (8.9.3/8.6.9) id KAA04055; Sat, 25 Sep 1999 10:23:40 -0700 (PDT)
To: Andreas Klemm <andreas@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: ports/print/apsfilter Makefile
References: <199909251711.KAA00809@freefall.freebsd.org>
From: asami@FreeBSD.org (Satoshi - Ports Wraith - Asami)
Date: 25 Sep 1999 10:23:37 -0700
In-Reply-To: Andreas Klemm's message of "Sat, 25 Sep 1999 10:11:22 -0700 (PDT)"
Message-ID: <vqcso42lxba.fsf@silvia.hip.berkeley.edu>
Lines: 18
X-Mailer: Gnus v5.7/Emacs 20.4
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

 *   Modified files:
 *     print/apsfilter      Makefile 
 *   Log:
 *   added configure script with dialog utility like in apache13-php3 port,
 *   that offers the user a menue, where he enters
 *   	- PAPERSIZE
 *   	- file type support for apsfilter

Thanks, but why are you putting the generated Makefile.inc in
${WRKDIRPREFIX}${.CURDIR} instead of ${WRKDIR}?  The latter will
surely make your Makefile much simpler.

Actually I don't even understand why you just didn't use pre-clean
instead of copying the entire "clean" target from bsd.port.mk (which
is usually not a very good idea) just to add a post-clean like
functionality. ;)

Satoshi


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message