Date: Sat, 20 Oct 2012 08:40:48 -0400 From: John Baldwin <jhb@freebsd.org> To: Alberto Villa <avilla@freebsd.org> Cc: freebsd-acpi@freebsd.org, Juergen Lock <nox@jelal.kn-bremen.de>, mobile@freebsd.org Subject: Re: Dell acpi_video patch Message-ID: <201210200840.48613.jhb@freebsd.org> In-Reply-To: <CAJp7RHY1DfhYu=qWL1jV7ProD05gOR%2BsL4HmUw6oMb7HsTJjHA@mail.gmail.com> References: <20121005215316.GA38707@triton8.kn-bremen.de> <201210191313.14246.jhb@freebsd.org> <CAJp7RHY1DfhYu=qWL1jV7ProD05gOR%2BsL4HmUw6oMb7HsTJjHA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, October 19, 2012 06:21:00 PM Alberto Villa wrote: > On Fri, Oct 19, 2012 at 7:13 PM, John Baldwin <jhb@freebsd.org> wrote: > > Yes, unless bit 31 is set, we can't know anything about bits 0-15 except > > that they are "unique". Specifically, we can't look at the "Display > > Type" bits to determine if an output device is a CRT vs LCD vs TV, etc. > > You can only do that if bit 31 is set. > > I know, I was saying that you probably confused bit 31 with bit 16, so > the patch you proposed (about bit 31 being set in _DOD but not in > _ADR) was not correct. ;) Oh, no, I hadn't been able to tell from your ASL that bit 16 was set (it's not that easy to guess as it computes the ID's dynamically at runtime. I was merely guessing that since I had changed the matching logic to look at bit 31 that that was the cause, but it wasn't the matching logic that was different (comparing _ADR to _DOD), but the logic that parsed _DOD is what treated your laptop differently. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210200840.48613.jhb>