Date: Thu, 5 Aug 2010 16:40:12 GMT From: Andriy Gapon <avg@icyb.net.ua> To: freebsd-fs@FreeBSD.org Subject: Re: kern/148655: [zfs] Booting from a degraded raidz no longer works in 8-STABLE [regression] Message-ID: <201008051640.o75GeCR1003675@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/148655; it has been noted by GNATS.
From: Andriy Gapon <avg@icyb.net.ua>
To: Martin Matuska <mm@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, am@raisa.eu.org,
Pawel Jakub Dawidek <pjd@FreeBSD.org>, Xin LI <delphij@FreeBSD.org>
Subject: Re: kern/148655: [zfs] Booting from a degraded raidz no longer works
in 8-STABLE [regression]
Date: Thu, 05 Aug 2010 19:38:17 +0300
on 05/08/2010 19:23 Martin Matuska said the following:
> A proposed patch is attached.
>
> The function vdev_read_phys() (sys/boot/zfs/zfsimpl.c, #325) does call
> vdev->v_phys_read() without checking if that function is registered.
>
> This check should be done in vdev_read_phys before doing anything else.
>
> vdev_create initializes vdev->v_phys_read as 0 and unavailable vdevs
> keep this value.
Looks very good.
Thanks!
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201008051640.o75GeCR1003675>