From owner-svn-ports-all@freebsd.org Thu Aug 31 09:05:01 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2B70E19BFD; Thu, 31 Aug 2017 09:05:01 +0000 (UTC) (envelope-from ehaupt@critical.ch) Received: from critical.ch (critical.ch [IPv6:2a01:4f8:c17:de4::1:1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "critical.ch", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 603AB6FA67; Thu, 31 Aug 2017 09:05:01 +0000 (UTC) (envelope-from ehaupt@critical.ch) Received: from wiggles.local (dynamic.wline.6rd.res.cust.swisscom.ch [IPv6:2a02:1205:5009:f430:dad3:85ff:fe79:dd2] (may be forged)) (authenticated bits=0) by critical.ch (8.15.2/8.15.2/critical-1.0) with ESMTPSA id v7V94uOk046134 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 31 Aug 2017 11:04:58 +0200 (CEST) (envelope-from ehaupt@critical.ch) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=critical.ch; s=critical; t=1504170299; bh=yIS3XT9emDLankt9ijkE4rOCRLeMLwbd/H+bJztPLkk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=o0za61fdVeGWkTkiAXgO3oDQEivKLiZgaQupbobsrlnlXfo8DezLZyAzJvzFMUMg4 lAVBL0P0H56pJXWP4iArNJ3e0nXTympfjn4vrzrZsFD0/08LPKWUHg91lHVD+TUXgh DWD7BDvjiGyI7QaP63eohpaXMGUGYBUqA1vbh9o0= Date: Thu, 31 Aug 2017 11:04:51 +0200 From: Emanuel Haupt To: Dan Langille Cc: Jan Beich , Dan Langille , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r448998 - head/net-mgmt/tcpreplay Message-Id: <20170831110451.1ec8b8a6dac597f5ec567782@critical.ch> In-Reply-To: <01088B7D-A035-458C-9A23-70EA8381AE66@langille.org> References: <201708301932.v7UJW1tH094312@repo.freebsd.org> <1sns-okrn-wny@FreeBSD.org> <01088B7D-A035-458C-9A23-70EA8381AE66@langille.org> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; amd64-portbld-freebsd11.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 09:05:01 -0000 Dan Langille wrote: > > On Aug 30, 2017, at 4:36 PM, Jan Beich wrote: > > > > Dan Langille writes: > > > >> Author: dvl > >> Date: Wed Aug 30 19:32:00 2017 > >> New Revision: 448998 > >> URL: https://svnweb.freebsd.org/changeset/ports/448998 > >> > >> Log: > >> Add base/port options for libpcap > > [...] > >> +OPTIONS_DEFINE= LIBPCAP_BASE LIBPCAP_PORTS > > [...] > >> +OPTIONS_SINGLE= SG1 > >> +OPTIONS_SINGLE= LIBPCAP_BASE LIBPCAP_PORTS > > > > _SINGLE declares a group of options, not the option themselves. > > When _SINGLE is overloaded by _DEFINE the option is no longer > > exclusive. > > > > Did you forget to adjust Porter's Handbook example? > > So it seems, thank you. > > > OPTIONS_SINGLE= LIBPCAP > > OPTIONS_SINGLE_LIBPCAP= LIBPCAP_BASE LIBPCAP_PORTS > > > >> +OPTIONS_DEFAULT= LIBPCAP_BASE > > > > Doesn't work if net/libpcap is installed as a dependency by another > > (unrelated) port. > > What do you mean by doesn't work? > > tcpreplay will work. It will use the lib in base, and ignore the lib > provided by net/libpcap > > Do I misunderstand? > > > +LIBPCAP_PORTS_BUILD_DEPENDS= > > ${LOCALBASE}/lib/libpcap.a:net/libpcap > >> +LIBPCAP_PORTS_LIB_DEPENDS= libpcap.so:net/libpcap > > > > Maybe drop _BUILD_DEPENDS hack by adding .1 suffix to _LIB_DEPENDS. > > I don't understand the .1 - did i miss another handbook item? I'm committing a patch shortly to address those issues.