From owner-cvs-all Sat Jan 27 22:26:20 2001 Delivered-To: cvs-all@freebsd.org Received: from magnesium.net (toxic.magnesium.net [207.154.84.15]) by hub.freebsd.org (Postfix) with SMTP id 585A437B698 for ; Sat, 27 Jan 2001 22:25:58 -0800 (PST) Received: (qmail 35231 invoked by uid 1142); 28 Jan 2001 06:25:57 -0000 Date: 27 Jan 2001 22:25:57 -0800 Date: Sat, 27 Jan 2001 22:25:52 -0800 From: Jason Evans To: John Baldwin Cc: Bosko Milekic , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 mp_machdep.c Message-ID: <20010127222552.S87569@canonware.com> References: <200101280341.f0S3f1s35766@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Sat, Jan 27, 2001 at 10:14:25PM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Jan 27, 2001 at 10:14:25PM -0800, John Baldwin wrote: > > On 28-Jan-01 Bosko Milekic wrote: > > bmilekic 2001/01/27 19:41:01 PST > > > > Modified files: > > sys/i386/i386 mp_machdep.c > > Log: > > Move the setting of curproc to idleproc up earlier in ap_init(). The > > problem is that a mutex lock, prior to this change, is acquired before > > the curproc is set to idleproc, so we mess ourselves up by calling > > the mutex lock routine with curproc == NULL. > > > > Moving it up after the aps_ready spin-wait has us hopefully setting it > > after idleproc is setup. > > > > Solved by: jake (the allmighty) :-) > > Forgotten by: jasone > > Actually, what I suggested to jasone (and kind of preferred myself) was to set > each curproc in the AP's when we initialized the idleprocs. This has the > benefit of being MI: Actually, I didn't forget it; the machine wouldn't boot with that change in place, so I took it back out. Jason To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message