Date: Fri, 11 Jan 2008 10:09:55 +0100 (CET) From: Oliver Fromme <olli@lurza.secnetix.de> To: freebsd-current@FreeBSD.ORG, atrens@nortel.com Subject: Re: powerd adaptive mode latching Message-ID: <200801110909.m0B99tlr097501@lurza.secnetix.de> In-Reply-To: <47824627.40701@nortel.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrew Atrens wrote: > # cvs diff -u acpi_perf.c > Index: acpi_perf.c > =================================================================== > RCS file: /usr/repo/freebsd/src/sys/dev/acpica/acpi_perf.c,v > retrieving revision 1.26 > diff -u -r1.26 acpi_perf.c > - --- acpi_perf.c 22 Mar 2007 18:16:40 -0000 1.26 > +++ acpi_perf.c 16 Nov 2007 20:11:02 -0000 > @@ -300,9 +300,9 @@ > continue; > > /* Check for duplicate entries */ > - - if (count > 0 && > - - sc->px_states[count - 1].core_freq == > - - sc->px_states[count].core_freq) > + if (count > 0 && > + CPUFREQ_CMP(sc->px_states[count - 1].core_freq, > + sc->px_states[count].core_freq)) > continue; > > count++; > > > It's so simple that it's kind of silly that it (or something like it) > hasn't been committed yet... > > Anyone out there with a commit bit interested in submitting this ? It seems that nobody is responsible for those things right now (or nobody feels responsible). My PR bin/115513 is also still open. I'm using that patch for a long time already and wouldn't want to live without it; it improves interactive behaviour a lot on my notebook with powerd. Best regards Oliver -- Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M. Handelsregister: Registergericht Muenchen, HRA 74606, Geschäftsfuehrung: secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün- chen, HRB 125758, Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart FreeBSD-Dienstleistungen, -Produkte und mehr: http://www.secnetix.de/bsd "Being really good at C++ is like being really good at using rocks to sharpen sticks." -- Thant Tessman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801110909.m0B99tlr097501>