Date: Sat, 10 Sep 2011 00:41:18 -0400 From: Eitan Adler <lists@eitanadler.com> To: Aioanei Rares <schaiba@gmail.com> Cc: freebsd-ports@freebsd.org Subject: Re: Standalone mksh Message-ID: <CAF6rxg=eo22yYaMk5q8X9U8D5_pmB9QkmLG91oCv=thHW_qbcw@mail.gmail.com> In-Reply-To: <CABasXZVXWew6%2BO3RYgnN4d39UhXPKf_Y7hTsi3q_-KFLTq-FvA@mail.gmail.com> References: <CABasXZVXWew6%2BO3RYgnN4d39UhXPKf_Y7hTsi3q_-KFLTq-FvA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> I wanted to propose the addition of a standalone mksh in shells/, which , of > course, is compiled with -static and installs to /bin . Attached is the > modified Makefile. 1) Please submit unified diffs, not entire files. It makes it easier to see what changed and it makes it easier to actually use when testing 2) We assume that LOCALBASE is read only (except for some very specific hacks like perl's symlink) so such a port will not be committed 3) Don't change PREFIX in the port's Makefile. This is a user specific option which should not be overwritten 4) If anything, the -static should be an OPTION. 5) Your change would require approval by the maintainer (miwi@FreeBSD.org). I would hope he does not approve it based on points 2-4 above. Thanks for your contribution. Please don't take my criticism of this specific patch as reason not to try again! -- Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=eo22yYaMk5q8X9U8D5_pmB9QkmLG91oCv=thHW_qbcw>