Date: Sun, 03 Nov 2013 23:56:23 +0100 From: Matthias Andree <mandree@FreeBSD.org> To: freebsd-ports@freebsd.org Subject: Re: Problems with "spaces" in file names during stage-qa Message-ID: <5276D497.5040009@FreeBSD.org> In-Reply-To: <52764CA9.9020705@freebsd.org> References: <5275C412.4000909@freebsd.org> <52764CA9.9020705@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 03.11.2013 14:16, schrieb Danilo E. Gondolfo: > Hello folks, > > I've had some problems with blank chars in file names during stage-qa. > > Problems like that: > > ====> Running Q/A tests (stage-qa) > sed: > /home/barba/Sources/freebsd-working/ports/games/lincity-ng/work/stage/usr/local/share/lincity-ng/music/01: > No such file or directory > sed: -: No such file or directory > sed: pronobozo: No such file or directory > sed: -: No such file or directory > sed: lincity.ogg: No such file or directory > sed: > /home/barba/Sources/freebsd-working/ports/games/lincity-ng/work/stage/usr/local/share/lincity-ng/music/03: > No such file or directory > sed: -: No such file or directory > sed: Robert: No such file or directory > sed: van: No such file or directory > sed: Herk: No such file or directory > sed: -: No such file or directory > sed: Architectural: No such file or directory > sed: Contemplations.ogg: No such file or directory > sed: > /home/barba/Sources/freebsd-working/ports/games/lincity-ng/work/stage/usr/local/share/lincity-ng/music/02: > No such file or directory > sed: -: No such file or directory > sed: Robert: No such file or directory > sed: van: No such file or directory > sed: Herk: No such file or directory > sed: -: No such file or directory > sed: City: No such file or directory > sed: Blues.ogg: No such file or directory > > > I've fixed this with the attached patch. What do you think? Thanks for taking a stab at this. However, the patch goes only halfway. If we really want to proof it against blanks, we need to tweak IFS - and that would still not proof it against tabs or line feeds in filenames. As reference, I found David A. Wheeler's article most elucidating: <http://www.dwheeler.com/essays/filenames-in-shell.html>; Would you like to take another, more robust, stab at the script?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5276D497.5040009>