From owner-freebsd-ports@FreeBSD.ORG Sun Aug 29 14:10:44 2010 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C7C71065675; Sun, 29 Aug 2010 14:10:44 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id B4EF78FC26; Sun, 29 Aug 2010 14:10:43 +0000 (UTC) Received: by iwn36 with SMTP id 36so4702414iwn.13 for ; Sun, 29 Aug 2010 07:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=MjYkygN4m9+Bim6caVKdQaMLgRIT3km65v36i6Z3kkY=; b=JqacahhHtG63ViR38QEHGHaQyKBs7PIQYsSxeJGN+f38VwkvMt7xPJR4l3myTtXbw8 HM4lfRfhKYdFx2P6G5D5U9CGWC4Vsvu1oxhYiL7NZLG4ino6+4t6aMx4JU1lYvVxSS5X CQDWn9eWKVIb3FDhZpmAzm4P8AX7iiadwVTt0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=Pxesq4QOMz6mhTJYB4dosRKDbiEbJnqtYK0BuPh3simBqmtuykylNfUpc8ZPhAKr8G SMq/OIiBxJte/BE/XtNfSMtjMQZk5zsXp76QbCztnY49qPquGF1Lb90X/l7mdbDFDK9Y k2DR6XUA9kXdvcxVKkV7mFM6Gfdli4zcMQ/QQ= Received: by 10.231.187.194 with SMTP id cx2mr3708007ibb.165.1283091043273; Sun, 29 Aug 2010 07:10:43 -0700 (PDT) Received: from centel.dataix.local (adsl-99-181-137-20.dsl.klmzmi.sbcglobal.net [99.181.137.20]) by mx.google.com with ESMTPS id z6sm4456756ibc.18.2010.08.29.07.10.41 (version=SSLv3 cipher=RC4-MD5); Sun, 29 Aug 2010 07:10:42 -0700 (PDT) Sender: "J. Hellenthal" Message-ID: <4C7A6A60.3090309@DataIX.net> Date: Sun, 29 Aug 2010 10:10:40 -0400 From: jhell User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.8) Gecko/20100806 Lightning/1.0b1 Thunderbird MIME-Version: 1.0 To: olli hauer References: <4C7A4FD0.1050304@DataIX.net> <4C7A5E20.4060302@gmx.de> In-Reply-To: <4C7A5E20.4060302@gmx.de> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: FreeBSD Ports , gordon@freebsd.org Subject: Re: devel/p4d patch X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Aug 2010 14:10:44 -0000 On 08/29/2010 09:18, olli hauer wrote: > On 2010-08-29 14:17, jhell wrote: >> Hi Gordon, >> >> I just upgraded devel/p4d port and you might find this patch >> interesting. This port would previously bail out trying to display the >> pkg-message file that it can't find without a path. >> >> On a second note. Where it displays this message ``post-install'' does >> not seem like the right place to display this message as it is not >> really noticeable during that stage. But to solve this file not being >> found I patched it up with the following. >> >> --- Makefile.orig 2010-08-29 08:08:25.801295898 -0400 >> +++ Makefile 2010-08-29 08:10:49.149776482 -0400 >> @@ -49,7 +49,7 @@ >> ${INSTALL_PROGRAM} ${_DISTDIR}/p4d ${PREFIX}/sbin/ >> >> post-install: >> - @${CAT} pkg-message >> + @${CAT} ${PORTSDIR}/devel/${PORTNAME}/pkg-message >> ${MKDIR} ${DESTDIR}${P4ROOT} >> ${CHOWN} p4admin:p4admin ${DESTDIR}${P4ROOT} >> ${CHMOD} 750 ${DESTDIR}${P4ROOT} >> >> > > Hi J, > > this will only work if you install via ports but not via package. > > Try '@${CAT} ${PKGMESSAGE}' instead, the port system will find > the file and it will be displayed during (package) install. > > post-install is the right section, but I agree the message can be > overlooked easily, this is one of the reason some pkg-messages > start and end with a line of '=' signs and have some blanks > between the '====..' line and the message self. > Hi Olli, Thank you for the feedback. I knew there was something more to it!. Good to know that is the right place for this. Maybe adding a @${ECHO} to the bottom and top of that statement to echo a separation line would make it more clear. Leaving it up to Gordon as I just wanted to inform him about the error so it can be fixed. Thank you again & Regards, -- jhell,v