From owner-cvs-all Sun Jun 3 22:45:15 2001 Delivered-To: cvs-all@freebsd.org Received: from mail.chem.msu.ru (mail.chem.msu.ru [195.208.208.19]) by hub.freebsd.org (Postfix) with ESMTP id AABF537B401; Sun, 3 Jun 2001 22:45:06 -0700 (PDT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su ([158.250.32.97]) by mail.chem.msu.ru with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21) id LR567XRR; Mon, 4 Jun 2001 09:42:00 +0400 Received: (from yar@localhost) by comp.chem.msu.su (8.11.1/8.11.1) id f545j4048540; Mon, 4 Jun 2001 09:45:04 +0400 (MSD) (envelope-from yar) Date: Mon, 4 Jun 2001 09:45:03 +0400 From: Yar Tikhiy To: Greg Lehey Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, freebsd-arch@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_gif.c Message-ID: <20010604094503.A43248@comp.chem.msu.su> References: <200106031731.f53HVBA42280@freefall.freebsd.org> <20010604094827.N85812@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010604094827.N85812@wantadilla.lemis.com>; from grog@FreeBSD.org on Mon, Jun 04, 2001 at 09:48:27AM +0930 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG [Added freebsd-arch to the Cc: list] On Mon, Jun 04, 2001 at 09:48:27AM +0930, Greg Lehey wrote: > On Sunday, 3 June 2001 at 10:31:11 -0700, Yar Tikhiy wrote: > > yar 2001/06/03 10:31:11 PDT > > > > Modified files: > > sys/net if_gif.c > > Log: > > First, wrap the if_up() call into splimp()/splx() because > > if_up() must be called at splnet or higher. > > Second, set the IFF_RUNNING flag on an interface after its > > resources (i.e. tunnel source and destination addresses) > > have been set. Note that we don't set IFF_UP because it is > > if_up()'s job to do that. > > Presumably this is in preparation for an MFC? splimp() and splx() are > nops in -CURRENT. Thank you for pointing me out that. Indeed, I've missed the change. BTW, could anyone tell me what is the modern state of affairs as to locks in the networking code? The comments and man pages are still talking about splnet in -current, so they need to be fixed, but what should one write there instead? The IF_ENQUEUE case is obvious: Forget about splnet() and the manual modification of counters, just use IF_HANDOFF instead of IF_ENQUEUE. But what about other places where splnet/splimp is used? There are quite a few of them there... -- Yar To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message