Date: Thu, 04 Sep 2003 10:35:15 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Doug Rabson <dfr@nlsystems.com> Cc: "M. Warner Losh" <imp@bsdimp.com> Subject: Re: cvs commit: src/sys/pci if_sis.c if_sisreg.h Message-ID: <1199.1062664515@critter.freebsd.dk> In-Reply-To: Your message of "04 Sep 2003 09:16:54 BST." <1062663414.86530.15.camel@herring.nlsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <1062663414.86530.15.camel@herring.nlsystems.com>, Doug Rabson write s: >For specific drivers, if they really want to change the device >description in attach (why not do it in probe like every other driver), In the case of the sis driver, the "silicon revision register" is stored somewhere in BAR0, so I cannot examine it until the resources are allocated. I know there are other drivers which could be similarly more detailed of the description were set in attach rather than probe. I think postpoining the print to after attach might make sense. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1199.1062664515>