From owner-cvs-all Sun Nov 12 22:15:11 2000 Delivered-To: cvs-all@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.100.7]) by hub.freebsd.org (Postfix) with ESMTP id D1FE137B479; Sun, 12 Nov 2000 22:15:06 -0800 (PST) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.9.3/8.9.3) with ESMTP id BAA400468; Mon, 13 Nov 2000 01:15:05 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <200011130544.VAA16031@freefall.freebsd.org> References: <200011130544.VAA16031@freefall.freebsd.org> Date: Mon, 13 Nov 2000 01:15:02 -0500 To: Garance A Drosehn , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org From: Garance A Drosihn Subject: Re: cvs commit: src/usr.sbin/lpr/lpd printjob.c Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG At 9:44 PM -0800 11/12/00, I (Garance A Drosehn) wrote: >gad 2000/11/12 21:44:50 PST > > Modified files: > usr.sbin/lpr/lpd printjob.c > Log: > Replace call to mktemp() with mkstemp. Also move where that call is > done, so the correct directory is being checked. The mkstemp() call > is meant to create a temp file for stderrs when running filters. This > update also fixes log-file processing for remote (rm=) queues which > specify an input filter (if=). Before, filter-errs were thrown away. > Now they'll be copied to the queue's logfile (lf=). I should mention that in this specific case, the call to mktemp was NOT a security exposure. Still, it doesn't hurt to change that to mkstemp while fixing other things, and it gets rid of the warning message when linking lpd. -- --- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message