Date: Wed, 17 Jul 2019 02:47:29 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Steve Wills <swills@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r506329 - head/multimedia/libva Message-ID: <5zo1-8p26-wny@FreeBSD.org> In-Reply-To: <a9906e0a-f738-d3e9-0a40-d0aa797c30be@FreeBSD.org> (Steve Wills's message of "Tue, 16 Jul 2019 16:52:15 -0400") References: <201907100116.x6A1GDuA002773@repo.freebsd.org> <554d91d4-b243-a73b-9761-57c7da31a8ce@FreeBSD.org> <ims1-bzrs-wny@FreeBSD.org> <a9906e0a-f738-d3e9-0a40-d0aa797c30be@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Steve Wills <swills@FreeBSD.org> writes:
> Hi,
>
> On 7/16/19 2:27 PM, Jan Beich wrote:
>>
>> Yep. Old -CURRENT/-STABLE snapshots were never supported[1]. Bug 238650
>> references commits for each branch.
>>
>> [1] in terms of security fixes, binary packages and, by extension,
>> building from source
>>
>
> Checking __FreeBSD_version would be a simpler change and avoid
> this. It wasn't bumped for this particular change, but 1300033 is
> probably close enough, no?
Did you miss the base change was MFC'd to several /stable branches?
What you propose would break declarative style in favor of unwieldy
conditional where snapshot ranges aren't tested by the package cluster.
When to garbage-collect it also becomes less clear.
.if (${OPSYS} == FreeBSD && (${OSVERSION} < 1103501 || \
(${OSVERSION} >= 1200000 && ${OSVERSION} < 1200513) || \
(${OSVERSION} >= 1300000 && ${OSVERSION} < 1300034)))
LDFLAGS+= -lpthread
.endif
Why do you care so much about -CURRENT snapshots with known vulnerabilities?
If you simply don't have time/resources to upgrade -CURRENT jails why not
locally revert the offending commit.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5zo1-8p26-wny>