Date: Tue, 20 Jan 2015 09:22:38 -0500 From: Ed Maste <emaste@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: Hans Petter Selasky <hps@selasky.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Sean Bruno <sbruno@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys Message-ID: <CAPyFy2BmKRZMnS7srQBF3Z6GKbGx8iDSf=GcS3U%2BLjjPvuPbbA@mail.gmail.com> In-Reply-To: <54B80CB6.5030102@FreeBSD.org> References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <54B7E287.80406@FreeBSD.org> <54B7E566.8050601@selasky.org> <20150115171430.GO15484@FreeBSD.org> <20150115171539.GP15484@FreeBSD.org> <54B80CB6.5030102@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15 January 2015 at 13:53, John Baldwin <jhb@freebsd.org> wrote: > > I think it's been a > clear practice with all other changes reviewed in phabric to date that > the committer only lists people in 'Reviewed by' who actually signed off > on the patch, not just the list of people asked to review it. This point is worth repeating. Phabricator is an add-on tool to aid in pre-commit review, but is not a required part of our process and doesn't change the meaning of commit message metadata fields. "Reviewed by" in a commit message means exactly what it always has: that those listed have reasonably carefully reviewed the change and are willing to put their name on it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2BmKRZMnS7srQBF3Z6GKbGx8iDSf=GcS3U%2BLjjPvuPbbA>