From owner-freebsd-embedded@FreeBSD.ORG  Thu Feb 18 10:27:23 2010
Return-Path: <owner-freebsd-embedded@FreeBSD.ORG>
Delivered-To: embedded@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 00E1E106566C
	for <embedded@freebsd.org>; Thu, 18 Feb 2010 10:27:23 +0000 (UTC)
	(envelope-from rpaulo@gmail.com)
Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.157])
	by mx1.freebsd.org (Postfix) with ESMTP id 8167F8FC12
	for <embedded@freebsd.org>; Thu, 18 Feb 2010 10:27:22 +0000 (UTC)
Received: by fg-out-1718.google.com with SMTP id e21so279285fga.13
	for <embedded@freebsd.org>; Thu, 18 Feb 2010 02:27:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:sender:subject:mime-version
	:content-type:from:in-reply-to:date:cc:content-transfer-encoding
	:message-id:references:to:x-mailer;
	bh=pmlv+9knG4fBl65RJ7Tc17PkEdALQtAEzN8L+dRBcPk=;
	b=Kz4FyYYOb1jBMcUDNgk8xo/MHXcEwvuUeCEe97kgTSCzgGGLaKVYppB1rGd6QU9NNq
	XqRKvMYjwf/0C0AS373+YjMSIkelX7tA0bk6robwWC+dxQt16kShreVGt3Qj7KLGS/o+
	rxMheqKJMWIcXF8CWGwBR2wh2zQ1qzvkHf1Vo=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc
	:content-transfer-encoding:message-id:references:to:x-mailer;
	b=a1LNAaIb47N+XXOjv8+shB23HGgKSok69VVg56oBaOzw/GKokZUJttNynpYMRpjY/k
	J9VK9/G+OYN5gQ5fUro3CDM3E11FsW34FnKGj7FUAL6TlbQ97SrVB48yIgg7jn5rKC7P
	Dbv9lHka3H4GRd1aDK4B+7KPZAWcMgZesqK9k=
Received: by 10.86.233.20 with SMTP id f20mr3255944fgh.30.1266487474147;
	Thu, 18 Feb 2010 02:04:34 -0800 (PST)
Received: from ?10.0.10.4? (54.81.54.77.rev.vodafone.pt [77.54.81.54])
	by mx.google.com with ESMTPS id 15sm4566118fxm.10.2010.02.18.02.04.31
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Thu, 18 Feb 2010 02:04:32 -0800 (PST)
Sender: Rui Paulo <rpaulo@gmail.com>
Mime-Version: 1.0 (Apple Message framework v1077)
Content-Type: text/plain; charset=us-ascii
From: Rui Paulo <rpaulo@freebsd.org>
In-Reply-To: <42B59FCC-7A59-4383-BE4E-366B80B504BF@neville-neil.com>
Date: Thu, 18 Feb 2010 10:04:30 +0000
Content-Transfer-Encoding: quoted-printable
Message-Id: <A4CFBBFC-2680-4AA3-A613-53CF5B9178B3@freebsd.org>
References: <42B59FCC-7A59-4383-BE4E-366B80B504BF@neville-neil.com>
To: George Neville-Neil <gnn@neville-neil.com>
X-Mailer: Apple Mail (2.1077)
Cc: Joseph Koshy <jkoshy@freebsd.org>, embedded@freebsd.org,
	fabient@freebsd.org
Subject: Re: First cut at hwpmc support on MIPS
X-BeenThere: freebsd-embedded@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Dedicated and Embedded Systems <freebsd-embedded.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-embedded>
List-Post: <mailto:freebsd-embedded@freebsd.org>
List-Help: <mailto:freebsd-embedded-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Feb 2010 10:27:23 -0000

On 18 Feb 2010, at 04:32, George Neville-Neil wrote:

> Hi,
>=20
> I've got this running on my RouterStation Pro, which is a MIPS 24K =
(32bit) CPU.
> Please review and let me know if you have comments.  I'd like to =
commit this
> in a week or so.
>=20
> Best,
> George
>=20
> http://people.freebsd.org/~gnn/mipshwpmc_1.diff
>=20

o sys/modules/hwpmc/Makefile: there's some debugging left on
o Is it really necessary to add the file to =
sys/mips/atheros/files.ar71xx too? I thought sys/conf/files.mips was =
sufficient.

The rest looks good, thanks.
--
Rui Paulo