From owner-svn-src-all@freebsd.org  Fri Jun 16 15:54:00 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2BFABC7716B;
 Fri, 16 Jun 2017 15:54:00 +0000 (UTC)
 (envelope-from andrew@fubar.geek.nz)
Received: from fry.fubar.geek.nz (fry.fubar.geek.nz [139.59.165.16])
 by mx1.freebsd.org (Postfix) with ESMTP id ECAD9921;
 Fri, 16 Jun 2017 15:53:59 +0000 (UTC)
 (envelope-from andrew@fubar.geek.nz)
Received: from dhcp-10-248-112-187.eduroam.wireless.private.cam.ac.uk
 (global-5-143.nat-2.net.cam.ac.uk [131.111.5.143])
 by fry.fubar.geek.nz (Postfix) with ESMTPSA id E0E7B4E6E1;
 Fri, 16 Jun 2017 15:53:58 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: svn commit: r320002 - head/sys/arm/arm
From: Andrew Turner <andrew@fubar.geek.nz>
In-Reply-To: <201706161353.v5GDr2ig085413@repo.freebsd.org>
Date: Fri, 16 Jun 2017 16:53:58 +0100
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <7A647614-6401-42EE-B843-54F9D15A0749@fubar.geek.nz>
References: <201706161353.v5GDr2ig085413@repo.freebsd.org>
To: Zbigniew Bodek <zbb@freebsd.org>
X-Mailer: Apple Mail (2.3273)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Jun 2017 15:54:00 -0000


> On 16 Jun 2017, at 14:53, Zbigniew Bodek <zbb@freebsd.org> wrote:
>=20
> Author: zbb
> Date: Fri Jun 16 13:53:02 2017
> New Revision: 320002
> URL: https://svnweb.freebsd.org/changeset/base/320002
>=20
> Log:
>  Minor style improvements to pmap_remap_vm_attr()
>=20
>  Use correct platform_ function name in the comment and remove
>  redundant tabs.
>=20
> Modified:
>  head/sys/arm/arm/pmap-v6.c
>=20
> Modified: head/sys/arm/arm/pmap-v6.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/arm/arm/pmap-v6.c	Fri Jun 16 10:16:24 2017	=
(r320001)
> +++ head/sys/arm/arm/pmap-v6.c	Fri Jun 16 13:53:02 2017	=
(r320002)
> @@ -508,7 +508,7 @@ pmap_set_tex(void)
>  * Usage rules:
>  * - it shall be called after pmap_bootstrap_prepare() and before
>  *   cpu_mp_start() (thus only on boot CPU). In practice, it's =
expected
> - *   to be called from platform_attach() or platform_late_init().
> + *   to be called from platform_probe_and_attach() or =
platform_late_init().

That was correct. The armv6 SoC code should be using PLATFORM and =
implement the platform_attach() method. It=E2=80=99s a bug the Marvell =
code doesn=E2=80=99t.

Andrew=