Date: Thu, 27 Jun 2002 02:17:09 +0400 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Dag-Erling Smorgrav <des@ofug.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh-portable session.c Message-ID: <20020626221708.GA2178@nagual.pp.ru> In-Reply-To: <xzpznxh1z2q.fsf@flood.ping.uio.no> References: <200206261417.g5QEHTjR074759@freefall.freebsd.org> <20020626152357.GA30110@nagual.pp.ru> <xzpznxh1z2q.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 26, 2002 at 23:59:09 +0200, Dag-Erling Smorgrav wrote: > "Andrey A. Chernov" <ache@nagual.pp.ru> writes: > > About PATH: it seems that you expect that setusercontext() will set it, > > but setusercontext() can fail (its return code currently not checked, but > > was checked in our old code). It leaves code flow with no PATH. Better to > > set PATH before it & check its return code too. I am not sure about > > failure reaction, it can be fatal or just warning. > > Yes, that's a good point. The original code also assumes > setusercontext(3) will succeed, and copies the parent's PATH to the > child - but if setusercontext(3) failed, PATH might be anything (what > if sshd was started manually from a shell?) It should use a > compiled-in fallback instead. BTW, it seems we have a bug in our login(1), login.c - new code does setenv(PATH...) _after_ setusercontext(), it means path= command in standard /etc/login.conf will not works. > I disagree. The "term" variable is a fallback. You are right. I withdraw my notice about TERM. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020626221708.GA2178>