Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Jun 2019 12:48:32 +0200
From:      =?UTF-8?B?VMSzbA==?= Coosemans <tijl@FreeBSD.org>
To:        Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r503385 - head/Mk/Scripts
Message-ID:  <20190618124823.753dd639@kalimero.tijl.coosemans.org>
In-Reply-To: <20190618103203.n3v4qcghpqe5holn@ivaldir.net>
References:  <201906031257.x53Cvi9P092541@repo.freebsd.org> <20190615170158.489616a4@kalimero.tijl.coosemans.org> <20190618122504.791b3fcd@kalimero.tijl.coosemans.org> <20190618103203.n3v4qcghpqe5holn@ivaldir.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 18 Jun 2019 12:32:03 +0200 Baptiste Daroussin <bapt@FreeBSD.org>
wrote:
> On Tue, Jun 18, 2019 at 12:25:04PM +0200, T=C4=B3l Coosemans wrote:
>> On Sat, 15 Jun 2019 17:01:58 +0200 T=C4=B3l Coosemans <tijl@FreeBSD.org>
>> wrote: =20
>>> On Mon, 3 Jun 2019 12:57:44 +0000 (UTC) Mathieu Arnold <mat@FreeBSD.org>
>>> wrote: =20
>>>> Author: mat
>>>> Date: Mon Jun  3 12:57:44 2019
>>>> New Revision: 503385
>>>> URL: https://svnweb.freebsd.org/changeset/ports/503385
>>>>=20
>>>> Log:
>>>>   Use UCL for pkg-message
>>>>  =20
>>>>   Remain backward compatible but use ucl for the pkg-messages, which a=
llows to:
>>>>   - append messages one after the other
>>>>   - only print message on delete, install, upgrade from a version to a=
nother
>>>>  =20
>>>>   If pkg-message starts with a [ we consider it should be a valid ucl =
file
>>>>  =20
>>>>   The format is the following:
>>>>   [
>>>>   { message: "Always print" },
>>>>   { message: "package being removed", type: remove },
>>>>   { message: "package being installed", type: install },
>>>>   { message: "package is being upgraded", type: upgrade },
>>>>   { message: "Upgrading from lower than 1.0", maximum_version: "1.0", =
type: upgrade },
>>>>   { message: "Upgrading from higher than 1.0", minimum_version: "1.0",=
 type: upgrade  },
>>>>   { message: "Upgrading from >1.0 < 3.0", maximum_version: "3.0", mini=
mum_version: "1.0",
>>>>   ]
>>>>  =20
>>>>   Because it is ucl one can use some sugar like:
>>>>   [
>>>>   { message =3D <<EOD
>>>>   formatted
>>>>   message 'with fancy things'
>>>>   EOD
>>>>   },
>>>>   }   =20
>>>=20
>>> Can this be extended to include these fields:
>>> opsys: <operating system this message applies to>
>>> osversion: <list of os version ranges this message applies to>
>>> arch: <list of architectures this message applies to>
>>> options: <list of options that need to be on or off> =20
>>=20
>> Or should pkg-message just be created dynamically at package build time
>> in these cases? =20
>=20
> For now it is pretty simple on how it works.
>=20
> Yes we could imagine those extension easily, I will see what I can do.
> but in the mean time one can create pkg-message based on the option.

No need to rush.  It's just something that popped into my head when I
saw the firefox pkg-message.

> The only non easy one for me to add is the one based on options.

I'm not familiar with the syntax of UCL, but I imagine it would look
similar to the options section in the output of "pkg info -f firefox"?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190618124823.753dd639>