Date: Wed, 18 Jan 2017 10:14:00 -0800 From: Conrad Meyer <cem@freebsd.org> To: svn-src-head@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org Subject: Re: svn commit: r312391 - in head: share/man/man5 sys/ufs/ufs Message-ID: <CAG6CVpUUfvai=vaPD%2BUPvCXLHK3rQOkR_ceqxtHxZLtpiAkJnQ@mail.gmail.com> In-Reply-To: <201701181755.v0IHtnNX059783@repo.freebsd.org> References: <201701181755.v0IHtnNX059783@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 18, 2017 at 9:55 AM, Conrad E. Meyer <cem@freebsd.org> wrote: > Author: cem > Date: Wed Jan 18 17:55:49 2017 > New Revision: 312391 > URL: https://svnweb.freebsd.org/changeset/base/312391 > > Log: > ufs/extattr.h: Fix documentation of ea_name termination > > The ea_name string is not nul-terminated. Correct the documentation. > > Because the subsequent field is padded to 8 bytes, and the padding is > zeroed, the ea_name string will appear to be nul-terminated whenever th= e > length isn't exactly one (mod eight). > > This was introduced in r167010 (2007). > > Additionally, mark the length fields as unsigned. This particularly > matters for the single byte ea_namelength field, which can represent > extended attribute names up to 255 bytes long. > > No functional change. Whoops =E2=80=94 very minor functional change =E2=80=94 restore(8) can now = handle some dumps with extended attribute names longer than 127 characters that it couldn't before, due to the unsigned type change called out above. Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpUUfvai=vaPD%2BUPvCXLHK3rQOkR_ceqxtHxZLtpiAkJnQ>