Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Mar 2019 15:07:48 +0000 (UTC)
From:      Mateusz Piotrowski <0mp@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r496900 - head/games/asciiquarium
Message-ID:  <201903261507.x2QF7mj9079055@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: 0mp
Date: Tue Mar 26 15:07:47 2019
New Revision: 496900
URL: https://svnweb.freebsd.org/changeset/ports/496900

Log:
  games/asciiquarium: Clean up, install docs & set license
  
  - Standardize COMMENT
  - Set LICENSE
  - Fix shebang lines
  - Install documentation
  - Define do-test
  - Extend the pkg-descr a little bit
  
  Reviewed by:	krion
  Approved by:	krion (mentor), maintainer (timeout, > 14 days)
  Differential Revision:	https://reviews.freebsd.org/D19533

Modified:
  head/games/asciiquarium/Makefile
  head/games/asciiquarium/pkg-descr

Modified: head/games/asciiquarium/Makefile
==============================================================================
--- head/games/asciiquarium/Makefile	Tue Mar 26 14:28:10 2019	(r496899)
+++ head/games/asciiquarium/Makefile	Tue Mar 26 15:07:47 2019	(r496900)
@@ -3,24 +3,40 @@
 
 PORTNAME=	asciiquarium
 PORTVERSION=	1.1
+PORTREVISION=	1
 CATEGORIES=	games
 MASTER_SITES=	http://www.robobunny.com/projects/asciiquarium/
 DISTNAME=	${PORTNAME}_${PORTVERSION}
 
 MAINTAINER=	fjoe@FreeBSD.org
-COMMENT=	aquarium/sea animation in ASCII art
+COMMENT=	Aquarium/sea animation in ASCII art
 
+LICENSE=	GPLv2
+LICENSE_FILE=	${WRKSRC}/gpl.txt
+
 RUN_DEPENDS=	p5-Term-Animation>=0:devel/p5-Term-Animation
 
-USES=		perl5
+USES=		perl5 shebangfix
+SHEBANG_FILES=	asciiquarium
+
+NO_ARCH=	yes
 NO_BUILD=	yes
 
-WRKSRC=		${WRKDIR}/${DISTNAME}
-
 PLIST_FILES=	bin/asciiquarium
+PORTDOCS=	README
 
+OPTIONS_DEFINE=	DOCS
+
 do-install:
 	${INSTALL_SCRIPT} ${WRKSRC}/${PORTNAME} \
 		${STAGEDIR}${PREFIX}/bin/${PORTNAME}
+
+post-install-DOCS-on:
+	@${MKDIR} ${STAGEDIR}${DOCSDIR}
+	${INSTALL_DATA} ${WRKSRC}/README ${STAGEDIR}${DOCSDIR}
+
+do-test:
+	(sleep 0.1 && echo p && sleep 0.1 && echo p && sleep 0.1 && echo r && \
+		sleep 0.1 && echo q) | ${STAGEDIR}${PREFIX}/bin/asciiquarium
 
 .include <bsd.port.mk>

Modified: head/games/asciiquarium/pkg-descr
==============================================================================
--- head/games/asciiquarium/pkg-descr	Tue Mar 26 14:28:10 2019	(r496899)
+++ head/games/asciiquarium/pkg-descr	Tue Mar 26 15:07:47 2019	(r496900)
@@ -1,3 +1,5 @@
 Asciiquarium is an aquarium/sea animation in ASCII art.
 
+Enjoy the mysteries of the sea from the safety of your own terminal!
+
 WWW: http://www.robobunny.com/projects/asciiquarium/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903261507.x2QF7mj9079055>