Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Jan 2019 17:17:25 +0000 (UTC)
From:      Andriy Voskoboinyk <avos@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r343475 - head/sys/geom/uzip
Message-ID:  <201901261717.x0QHHPFd072279@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: avos
Date: Sat Jan 26 17:17:25 2019
New Revision: 343475
URL: https://svnweb.freebsd.org/changeset/base/343475

Log:
  geom_uzip(4): set 'gp != NULL' assertion on top of the function
  
  There was yet another access to this variable in g_trace() few
  lines upper.
  
  PR:		203499
  Reported by:	cem
  MFC after:	5 days
  MFC with:	343473

Modified:
  head/sys/geom/uzip/g_uzip.c

Modified: head/sys/geom/uzip/g_uzip.c
==============================================================================
--- head/sys/geom/uzip/g_uzip.c	Sat Jan 26 17:00:55 2019	(r343474)
+++ head/sys/geom/uzip/g_uzip.c	Sat Jan 26 17:17:25 2019	(r343475)
@@ -886,10 +886,10 @@ g_uzip_destroy_geom(struct gctl_req *req, struct g_cla
 {
 	struct g_provider *pp;
 
+	KASSERT(gp != NULL, ("NULL geom"));
 	g_trace(G_T_TOPOLOGY, "%s(%s, %s)", __func__, mp->name, gp->name);
 	g_topology_assert();
 
-	KASSERT(gp != NULL, ("NULL geom"));
 	if (gp->softc == NULL) {
 		DPRINTF(GUZ_DBG_ERR, ("%s(%s): gp->softc == NULL\n", __func__,
 		    gp->name));



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201901261717.x0QHHPFd072279>