Date: Sun, 16 Jan 2005 19:51:35 -0500 From: Garance A Drosihn <drosih@rpi.edu> To: Robert Watson <rwatson@freebsd.org>, "David O'Brien" <obrien@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: gratuitous gcc warnings: unused function arguments? Message-ID: <p06200723be10ba368225@[128.113.24.47]> In-Reply-To: <Pine.NEB.3.96L.1050116210328.50371F-100000@fledge.watson.org> References: <Pine.NEB.3.96L.1050116210328.50371F-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At 9:05 PM +0000 1/16/05, Robert Watson wrote:
>On Sun, 16 Jan 2005, David O'Brien wrote:
>
> > We're not going to hack GCC to deal with this. That is going way
> > too far. This is coming up because people are using high WARNS
> > values in Makefiles. Either back them down to a lower WARNS value;
> > or we should add -Wno-unused-parameter to WARNS level 3.
>
>I'd be fine with simply pushing threshold for unused parameters up
>a few notches on the warning scale. I'd like to have access to the
>other interesting warnings are WARNS=3 and WARNS=4 relating to
>qualifiers, strings, etc.
I think it would be useful to keep that warning "in general", but
have an option to turn it off. The following seems to work for me,
assuming we can decide on the best name for a new NO_WUNUSED_ARGS
option:
Index: bsd.sys.mk
===================================================================
RCS file: /usr/cvs/free/depot/src/share/mk/bsd.sys.mk,v
retrieving revision 1.35
diff -u -r1.35 bsd.sys.mk
--- bsd.sys.mk 12 Mar 2004 21:36:12 -0000 1.35
+++ bsd.sys.mk 17 Jan 2005 00:32:14 -0000
@@ -29,6 +29,9 @@
. if ${WARNS} > 5
CWARNFLAGS += -Wchar-subscripts -Winline -Wnested-externs
-Wredundant-decls
. endif
+. if defined(NO_WUNUSED_ARGS) && ${WARNS} < 5
+CWARNFLAGS += -Wno-unused-parameter
+. endif
. if ${WARNS} > 1 && ${WARNS} < 5
# XXX Delete -Wuninitialized by default for now -- the compiler doesn't
# XXX always get it right.
--
Garance Alistair Drosehn = gad@gilead.netel.rpi.edu
Senior Systems Programmer or gad@freebsd.org
Rensselaer Polytechnic Institute or drosih@rpi.edu
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p06200723be10ba368225>