From owner-svn-src-head@freebsd.org Sat Jan 2 22:52:42 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 301F8A5F029; Sat, 2 Jan 2016 22:52:42 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-ob0-x233.google.com (mail-ob0-x233.google.com [IPv6:2607:f8b0:4003:c01::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E99031F25; Sat, 2 Jan 2016 22:52:41 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-ob0-x233.google.com with SMTP id wp13so91254832obc.1; Sat, 02 Jan 2016 14:52:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=l/gFtd2kUqCyTLEUrQBCfY6MlQFhvDV4f+9glLTwxOY=; b=QtIu2g2tnhTo35A78KmDjMawbPqIPmAjOmyxXkfz/balctumrN5phVZZ2BL9B9Snfs hjvJHD1bxQICxLu360icCvm+Siq3VDlOf4F99lYADcVfn2I33Oo4dRQuNeji+CNpMArG DdwaPt7i8/Ylw9uJXuI1TTdhTat0ime5r6bUdE/WTA/rN898a07z1ABRNb/UvxsKv9q6 ufTbDIOt+IdEPy6MHzdb8BoQCwVXMw/bNcaYy/VZuJnK5bf3aL6PaVLOrIPY1v8w/yhM nqJdJxw3DUTIyr2UwUxZjDC6UjmPAI8+Gi2G690L10tR9u6BXtB1j5rEEBtbzAaggtuy Z/Zg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alumni-cwru-edu.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=l/gFtd2kUqCyTLEUrQBCfY6MlQFhvDV4f+9glLTwxOY=; b=m4JxR5UpOX2GyA90NGxbqvKYhMp43JD3Q7sYAcacYcILlw6hQeL8zRCpzKoQWbBeY6 AsgDl2LpU5PekgWJknsYq3onwoAVY5Z2Y5w0eTEEzm0tSMWgLFqY+zVqkH2Tm6LA84Ci YRNiq5Q360/HPBDLNF417kyxBAN2ksiS6YGmw/Qz1EaTb74MPJVXCRu2cwuA4V0n4Y7J nn6kBmFtkr5SDpCKh0D9W0kjwlWyRgXFw+zRY2WZtjetCGAursh5h3CDwNR4muSXwHK0 +jpANvKajZAyKEwoE+eoXm9A0QEtKixg7xT7qKgx0JihGMv31s3FKcv5hdBW8bP3fxJB gJtA== MIME-Version: 1.0 X-Received: by 10.182.241.3 with SMTP id we3mr53648584obc.82.1451775161079; Sat, 02 Jan 2016 14:52:41 -0800 (PST) Sender: chmeeedalf@gmail.com Received: by 10.182.184.84 with HTTP; Sat, 2 Jan 2016 14:52:41 -0800 (PST) In-Reply-To: <1451774801.1369.112.camel@freebsd.org> References: <201601021816.u02IGOXQ060620@repo.freebsd.org> <90CAFE3D-DB95-4790-8FBD-9C40E6BF1075@lists.zabbadoz.net> <1451774801.1369.112.camel@freebsd.org> Date: Sat, 2 Jan 2016 16:52:41 -0600 X-Google-Sender-Auth: VolWvz_IyXLr6if1kZMI-BvIy2I Message-ID: Subject: Re: svn commit: r293053 - head/sys/boot/uboot/lib From: Justin Hibbits To: Ian Lepore Cc: "Bjoern A. Zeeb" , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jan 2016 22:52:42 -0000 On Sat, Jan 2, 2016 at 4:46 PM, Ian Lepore wrote: > On Sat, 2016-01-02 at 22:20 +0000, Bjoern A. Zeeb wrote: >> > On 02 Jan 2016, at 18:16 , Ian Lepore wrote: >> > >> > Author: ian >> > Date: Sat Jan 2 18:16:24 2016 >> > New Revision: 293053 >> > URL: https://svnweb.freebsd.org/changeset/base/293053 >> > >> > Log: >> > Use 64-bit math when finding a block of ram to hold the kernel. >> > This fixes >> > a problem on 32-bit systems which have ram occupying the end of >> > the physical >> > address space -- for example, a block of ram at 0x80000000 with a >> > size of >> > 0x80000000 was overflowing 32 bit math and ending up with a >> > calculated size >> > of zero. >> > >> > This is a fix for one of the two problems mentioned in the PR. >> > Something >> > similar will need to be done on the kernel side before the PR is >> > closed. >> > >> > PR: 201614 >> > >> > Modified: >> > head/sys/boot/uboot/lib/copy.c >> >> >> This seems to have broken powerpc/powerpc64 worlds: >> >> ===> sys/boot/uboot/lib (all) >> cc1: warnings being treated as errors >> /scratch/tmp/bz/head.svn/sys/boot/uboot/lib/copy.c: In function >> 'uboot_loadaddr': >> /scratch/tmp/bz/head.svn/sys/boot/uboot/lib/copy.c:103: warning: cast >> from pointer to integer of different size >> --- copy.o --- >> *** [copy.o] Error code 1 >> > > Grrrr. Casting from a pointer to an integer of a different size is > exactly what I want to do, and I thought explicitly casting was a > rather elegant way of expressing that. > > -- Ian > > Casting through uintptr_t should solve the problem. - Justin