Date: Fri, 05 Feb 2010 20:01:34 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: neelnatu@gmail.com Cc: freebsd-mips@FreeBSD.org Subject: Re: Patch: SMP support for MIPS Message-ID: <20100205.200134.460114267490858629.imp@bsdimp.com> In-Reply-To: <dffe84831002051827r430c7fb6le3c3506bd6d38a03@mail.gmail.com> References: <dffe84831002051827r430c7fb6le3c3506bd6d38a03@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <dffe84831002051827r430c7fb6le3c3506bd6d38a03@mail.gmail.com>
Neel Natu <neelnatu@gmail.com> writes:
: I have put the diff here for review:
: http://people.freebsd.org/~neel/mips_smp_patch/diff.txt
+ /*
+ * XXX
+ * SMP kernels must delay pcpu initialization until after
+ * TLB has been flushed and initialized (see mips_cpu_init())
+ */
+ if (pcpu_find(0) == NULL)
+ mips_pcpu0_init();
+
The practical upshot of this change is that panic() prior to this
point will fault. Is there some way to avoid this?
The rest of these changes look fairly good. I'll likely comment on a
few nits later that I saw once I have the time to devote to it.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100205.200134.460114267490858629.imp>