Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Feb 2011 23:21:43 +0200
From:      Kostik Belousov <kostikbel@gmail.com>
To:        Josh Paetzel <jpaetzel@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r218959 - head/usr.sbin/pc-sysinstall/backend-query
Message-ID:  <20110222212143.GE78089@deviant.kiev.zoral.com.ua>
In-Reply-To: <201102221918.p1MJIukV018893@svn.freebsd.org>
References:  <201102221918.p1MJIukV018893@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--ys1XzWHRwUoZRcaf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 22, 2011 at 07:18:56PM +0000, Josh Paetzel wrote:
> Author: jpaetzel
> Date: Tue Feb 22 19:18:56 2011
> New Revision: 218959
> URL: http://svn.freebsd.org/changeset/base/218959
>=20
> Log:
>   Better method for grabbing disk name, dmesg may produce mangled output.
>  =20
>   Approved by:	kib (mentor, implicit)
>=20
> Modified:
>   head/usr.sbin/pc-sysinstall/backend-query/disk-list.sh
>=20
> Modified: head/usr.sbin/pc-sysinstall/backend-query/disk-list.sh
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/usr.sbin/pc-sysinstall/backend-query/disk-list.sh	Tue Feb 22 19:=
05:42 2011	(r218958)
> +++ head/usr.sbin/pc-sysinstall/backend-query/disk-list.sh	Tue Feb 22 19:=
18:56 2011	(r218959)
> @@ -74,7 +74,7 @@ do
>    fi
> =20
>    # Check the dmesg output for some more info about this device
Shouldn't the comment be updated ?

> -  NEWLINE=3D$(dmesg | sed -n "s/^$DEV: .*<\(.*\)>.*$/ <\1>/p" | head -n =
1)
> +  NEWLINE=3D$(camcontrol identify $DEV | grep "device model" | tr -s ' '=
 | sed 's |device model ||g')
>    if [ -z "$NEWLINE" ]; then
>      NEWLINE=3D" <Unknown Device>"
>    fi

--ys1XzWHRwUoZRcaf
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)

iEYEARECAAYFAk1kKOcACgkQC3+MBN1Mb4iHlACg4YCP2uWYkixh8S9tuwqK3rY+
nbYAoKlpuht0mekRtlgOiLEG8ulixev/
=SWa4
-----END PGP SIGNATURE-----

--ys1XzWHRwUoZRcaf--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110222212143.GE78089>