From owner-svn-ports-head@freebsd.org Tue Jun 18 10:51:07 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8220815B5842; Tue, 18 Jun 2019 10:51:07 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1DEEE6EE1B; Tue, 18 Jun 2019 10:51:07 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from ivaldir.etoilebsd.net (etoilebsd.net [178.32.217.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id C19CECD2A; Tue, 18 Jun 2019 10:51:06 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by ivaldir.etoilebsd.net (Postfix, from userid 1001) id F361DB4A39; Tue, 18 Jun 2019 12:51:05 +0200 (CEST) Date: Tue, 18 Jun 2019 12:51:05 +0200 From: Baptiste Daroussin To: =?utf-8?Q?T=C4=B3l?= Coosemans Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r503385 - head/Mk/Scripts Message-ID: <20190618105105.tnzwuw75e4biwv6f@ivaldir.net> References: <201906031257.x53Cvi9P092541@repo.freebsd.org> <20190615170158.489616a4@kalimero.tijl.coosemans.org> <20190618122504.791b3fcd@kalimero.tijl.coosemans.org> <20190618103203.n3v4qcghpqe5holn@ivaldir.net> <20190618124823.753dd639@kalimero.tijl.coosemans.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3ur6xxs5ytioza53" Content-Disposition: inline In-Reply-To: <20190618124823.753dd639@kalimero.tijl.coosemans.org> User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 1DEEE6EE1B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.987,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jun 2019 10:51:07 -0000 --3ur6xxs5ytioza53 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 18, 2019 at 12:48:32PM +0200, T=C4=B3l Coosemans wrote: > On Tue, 18 Jun 2019 12:32:03 +0200 Baptiste Daroussin > wrote: > > On Tue, Jun 18, 2019 at 12:25:04PM +0200, T=C4=B3l Coosemans wrote: > >> On Sat, 15 Jun 2019 17:01:58 +0200 T=C4=B3l Coosemans > >> wrote: =20 > >>> On Mon, 3 Jun 2019 12:57:44 +0000 (UTC) Mathieu Arnold > >>> wrote: =20 > >>>> Author: mat > >>>> Date: Mon Jun 3 12:57:44 2019 > >>>> New Revision: 503385 > >>>> URL: https://svnweb.freebsd.org/changeset/ports/503385 > >>>>=20 > >>>> Log: > >>>> Use UCL for pkg-message > >>>> =20 > >>>> Remain backward compatible but use ucl for the pkg-messages, which= allows to: > >>>> - append messages one after the other > >>>> - only print message on delete, install, upgrade from a version to= another > >>>> =20 > >>>> If pkg-message starts with a [ we consider it should be a valid uc= l file > >>>> =20 > >>>> The format is the following: > >>>> [ > >>>> { message: "Always print" }, > >>>> { message: "package being removed", type: remove }, > >>>> { message: "package being installed", type: install }, > >>>> { message: "package is being upgraded", type: upgrade }, > >>>> { message: "Upgrading from lower than 1.0", maximum_version: "1.0"= , type: upgrade }, > >>>> { message: "Upgrading from higher than 1.0", minimum_version: "1.0= ", type: upgrade }, > >>>> { message: "Upgrading from >1.0 < 3.0", maximum_version: "3.0", mi= nimum_version: "1.0", > >>>> ] > >>>> =20 > >>>> Because it is ucl one can use some sugar like: > >>>> [ > >>>> { message =3D < >>>> formatted > >>>> message 'with fancy things' > >>>> EOD > >>>> }, > >>>> } =20 > >>>=20 > >>> Can this be extended to include these fields: > >>> opsys: > >>> osversion: > >>> arch: > >>> options: =20 > >>=20 > >> Or should pkg-message just be created dynamically at package build time > >> in these cases? =20 > >=20 > > For now it is pretty simple on how it works. > >=20 > > Yes we could imagine those extension easily, I will see what I can do. > > but in the mean time one can create pkg-message based on the option. >=20 > No need to rush. It's just something that popped into my head when I > saw the firefox pkg-message. >=20 > > The only non easy one for me to add is the one based on options. >=20 > I'm not familiar with the syntax of UCL, but I imagine it would look > similar to the options section in the output of "pkg info -f firefox"? Yes I planned to use firefox as a guinea pig ;) Best regards, Bapt --3ur6xxs5ytioza53 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl0IwhkACgkQY4mL3PG3 PloUcRAAii2+13sgc/UjZukZM7hbJLukINuZZKegFyjxOX6JYZY0RHPL1Y4JeByT atTOle1P5hdZMzRwfYa9dMZ/IXhiGGe9PjaiTmx4dF9bhENOgW9pPFwAzPZpE7lP hdvvMCZdtomaV5BasbvxSXzWo3wHNvArquWV0cE595Xs1v9UDSIEWKsBgdNib6rM goXQ4h6t+Bc5fkJd62k4wJ7ng7rTdISnxWAKvY4z4jTKXaYb+BKI/s9pAk5mY8it s5BZ5q8jLtojKndn6s4h6k7Sg7/Di6EHw9b56XAmdM1PKihYbGAZGAP+sy+Boxhl AP4emTOWa9wN6fncdc77i24fvv5NW83EEkpggcRVlcYWLUc12GW/etCgHxOSWWy6 VzhL0OEa8YDu6KvYdYEXeD9x3KLIskErYpdgh5SGPCPDEXARQNMYXjwI0YY7V7Yh XWg6Bt9Hm0+V/j5mhbTPhqtm7RCZSpwL95AZV0DX8XzKQEQ7v9G08tDSraFAonhk y/tIzG7ms3Fao5xcqWq5gURd9I0/RVexjvp3HPJPPYDvxuP1BM8MjZyw7yE47Ybr zztpLh/QB8gxqx2kKIyAc+pkRfsvnyZLCydsMHcNEGeoIX1/jaRH9HNyOGsRD6BP rCO9ByicJvyqPxoOlQ4G+zMueGQzlBbL1HlJvX4jKxWAYnsbJAk= =ylgm -----END PGP SIGNATURE----- --3ur6xxs5ytioza53--