Skip site navigation (1)Skip section navigation (2)
Date:      Wed,  3 Oct 2007 14:15:41 -0400 (EDT)
From:      Wesley Shields <wxs@atarininja.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        corsmith@gmail.com, shipley@dis.org
Subject:   ports/116876: Unbreak net/pynids on AMD64 (requires a patch to net/libnet10)
Message-ID:  <20071003181541.B1B6C5C38@syn.atarininja.org>
Resent-Message-ID: <200710031820.l93IK14g073620@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         116876
>Category:       ports
>Synopsis:       Unbreak net/pynids on AMD64 (requires a patch to net/libnet10)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 03 18:20:01 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Wesley Shields
>Release:        FreeBSD 6.2-RELEASE-p5 amd64
>Organization:
>Environment:
System: FreeBSD syn.csh.rit.edu 6.2-RELEASE-p5 FreeBSD 6.2-RELEASE-p5 #7: Thu May 24 09:18:59 EDT 2007 root@syn.csh.rit.edu:/usr/obj/usr/src/sys/SMP amd64

>Description:
I decided to take a stab at getting net/pynids unbroken on AMD64.  I
found that building net/libnet10 with -fPIC at least gets pynids to
build properly.  I haven't done any run time testing of either port so
I'm hoping the maintainers will speak up on this change.  I've CC'ed
both the maintainers on this PR.

>How-To-Repeat:
http://pointyhat.freebsd.org/errorlogs/amd64-errorlogs/e.7.2007100120/py25-pynids-0.5_2.log

>Fix:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/net/pynids/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile	30 Sep 2007 08:12:36 -0000	1.5
+++ Makefile	3 Oct 2007 15:36:41 -0000
@@ -32,10 +32,6 @@
 
 .include <bsd.port.pre.mk>
 
-.if ${ARCH} == "amd64"
-BROKEN=		Does not compile; needs -fPIC
-.endif
-
 .if exists(${LIBNET_CONFIG})
 LIBNET_CFLAGS!=	${LIBNET_CONFIG} --cflags
 LIBNET_LIBS!=	${LIBNET_CONFIG} --libs






Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/net/libnet10/Makefile,v
retrieving revision 1.19
diff -u -r1.19 Makefile
--- Makefile	30 Sep 2007 04:47:11 -0000	1.19
+++ Makefile	3 Oct 2007 16:46:03 -0000
@@ -16,6 +16,8 @@
 MAINTAINER=	shipley@dis.org
 COMMENT=	A C library for creating IP packets
 
+CFLAGS+=	-fPIC
+
 USE_AUTOTOOLS=	autoconf:261
 WRKSRC=		${WRKDIR}/Libnet-${PORTVERSION}
 DOCSDIR=	${PREFIX}/share/doc/${PORTNAME}${PKGNAMESUFFIX}
Index: files/patch-Makefile.in
===================================================================
RCS file: /home/ncvs/ports/net/libnet10/files/patch-Makefile.in,v
retrieving revision 1.1
diff -u -r1.1 patch-Makefile.in
--- files/patch-Makefile.in	31 Jan 2007 14:09:49 -0000	1.1
+++ files/patch-Makefile.in	3 Oct 2007 16:46:03 -0000
@@ -1,5 +1,5 @@
---- Makefile.in.orig	Mon Feb  5 14:51:41 2001
-+++ Makefile.in	Mon Sep 25 18:26:09 2006
+--- Makefile.in.orig	2001-02-05 12:51:41.000000000 -0500
++++ Makefile.in	2007-10-03 12:45:33.000000000 -0400
 @@ -14,8 +14,8 @@
  exec_prefix =   @exec_prefix@
  srcdir      =   @srcdir@
@@ -11,6 +11,15 @@
  MAN_PREFIX  =   @MAN_PREFIX@
  
  LIBNET      =   libnet
+@@ -37,7 +37,7 @@
+ CC          =   @CC@
+ ENSUREDIR   =   $(srcdir)/ensure-dir.sh
+ INSTALL_DATA=   $(srcdir)/install-sh
+-CFLAGS      =   @CFLAGS@
++CFLAGS      +=  @CFLAGS@
+ CPPFLAGS    =   @CPPFLAGS@
+ OBJECTS     =   src/libnet_resolve.o\
+ 		src/libnet_socket.o\
 @@ -108,8 +108,8 @@
  	$(INSTALL_DATA) $(INCLUDE-M) $(DESTDIR)$(INC_PREFIX)$(LIBNET)
  	$(INSTALL_DATA) $(INCLUDE-A) $(DESTDIR)$(INC_PREFIX)$(LIBNET)
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071003181541.B1B6C5C38>