From owner-freebsd-stable@FreeBSD.ORG Tue Aug 17 19:34:41 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB5971065670 for ; Tue, 17 Aug 2010 19:34:41 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 364508FC16 for ; Tue, 17 Aug 2010 19:34:40 +0000 (UTC) Received: by wwb24 with SMTP id 24so5312575wwb.31 for ; Tue, 17 Aug 2010 12:34:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=ATRMAzH2t7nVc47vnJd65aQMUTPKJNAOH7/wNogqT68=; b=VqU9UxlOwddUuvXOCCHDVd/FbpuS26SUm171ZqT6HrZDWxBZ6T51zmAw6m2L/2utw9 GIjgxzw/+aQ2QkfWDnof6vZXPMOxjvYsQ1sB9/YXlqkW2MJD/6WApQ65tCRaoDyw+pXI +zfOosNdh7ejkiGCDRHXkmGR0aebGFRO7QDA8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=o2GEEm7nHmKdh4soT7noX/2Grv42HS0Isc+FSzNOZiU4EQgb1vx1rclLc3jKpONA2X iE95hPRVR/q9vwJsDxxUzc/X3XKruWxlPgPUxd2FZEIm2Qw+A0h7P4HgePAPMNpMhSqf HhMogitQF0e8JwlhsMsmsCZb99+U6CvRMwKcA= MIME-Version: 1.0 Received: by 10.216.179.20 with SMTP id g20mr6067584wem.45.1282073671292; Tue, 17 Aug 2010 12:34:31 -0700 (PDT) Received: by 10.216.48.6 with HTTP; Tue, 17 Aug 2010 12:34:31 -0700 (PDT) In-Reply-To: <20100817191420.GB6482@michelle.cdnetworks.com> References: <201006102031.o5AKVCH2016467@lava.sentex.ca> <201007021739.o62HdMOU092319@lava.sentex.ca> <20100702193654.GD10862@michelle.cdnetworks.com> <201008162107.o7GL76pA080191@lava.sentex.ca> <20100817185208.GA6482@michelle.cdnetworks.com> <20100817191420.GB6482@michelle.cdnetworks.com> Date: Tue, 17 Aug 2010 12:34:31 -0700 Message-ID: From: Jack Vogel To: pyunyh@gmail.com Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-stable@freebsd.org Subject: Re: RELENG_7 em problems (and RELENG_8) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Aug 2010 19:34:41 -0000 I believe the requirement of a context descriptor for most frames in the igb driver is just the way the hardware works, I've looked over the Linux driver again and it looks like they require the same. I don't believe its a big deal, just the added descriptor for the frame. Jack On Tue, Aug 17, 2010 at 12:14 PM, Pyun YongHyeon wrote: > On Tue, Aug 17, 2010 at 11:52:08AM -0700, Pyun YongHyeon wrote: > > On Mon, Aug 16, 2010 at 05:07:11PM -0400, Mike Tancsa wrote: > > > Hi Jack, > > > FYI, I am still seeing this same problem on RELENG_8 (code > > > as of today). Unfortunately I cant try Pyun's patch since the > > > underlying code has changed since then. > > > > > > em4@pci0:3:0:0: class=0x020000 card=0x34ec8086 chip=0x10d38086 > > > rev=0x00 hdr=0x00 > > > vendor = 'Intel Corporation' > > > device = 'Intel 82574L Gigabit Ethernet Controller (82574L)' > > > class = network > > > subclass = ethernet > > > cap 01[c8] = powerspec 2 supports D0 D3 current D0 > > > cap 05[d0] = MSI supports 1 message, 64 bit enabled with 1 message > > > cap 10[e0] = PCI-Express 1 endpoint max data 128(256) link x1(x1) > > > cap 11[a0] = MSI-X supports 5 messages in map 0x1c > > > > > > pci3: on pcib3 > > > em4: port 0x1000-0x101f > > > mem 0xb1900000-0xb191ffff,0xb1920000-0xb1923fff irq 16 at device 0.0 on > pci3 > > > em4: Using MSI interrupt > > > em4: [FILTER] > > > em4: Ethernet address: 00:15:17:ed:3e:c4 > > > > > > > Here is updated patch for HEAD and stable/8. > > http://people.freebsd.org/~yongari/em.csum_tso.20100817.patch > > > > It seems to work as expected under my limited environments. If > > you're using multiple Tx queues with em(4) it would be better to > > disable Tx checksum offloading as driver always have to create a > > new checksum context for each frame. This will effectively disable > > pipelined Tx data DMA which in turn greatly slows down Tx > > performance for small sized frames. The reason driver have to > > create a new checksum context when it uses multiple Tx queues comes > > from hardware limitation. The controller tracks only for the last > > context descriptor that was written such that driver does not know > > the state of checksum context configured in other Tx queue. > > Hope this helps. > > > > For igb(4) controllers, it seems we also need a way to avoid > creating a new checksum context for every Tx frame as we did in > em(4). Unlike em(4) controllers, igb(4) seems to maintain context > per queue such that we can safely reuse previously configured > context for a queue. > _______________________________________________ > freebsd-stable@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org" >