Date: Thu, 19 Nov 2015 09:04:39 -0600 From: Justin Hibbits <jrh29@alumni.cwru.edu> To: Dan Partelly <dan_partelly@rdsor.ro> Cc: Willem Jan Withagen <wjw@digiware.nl>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: DDB patches Message-ID: <CAHSQbTD7B_U78y8xWed%2BeEwqQ9A3Y2ZMP_=VfzY2N9eaL6G5_A@mail.gmail.com> In-Reply-To: <78FDD0DE-5CA0-44AB-B46C-9C95E4F8DA5B@rdsor.ro> References: <B6FDC307-13EB-48AC-8130-C597AB8C06F4@rdsor.ro> <B6BF97C8-9FE3-4ADE-A047-33AF0B879781@freebsd.org> <22918FB9-4DC2-438D-B9F0-C295DD273B50@rdsor.ro> <564DD241.9020801@digiware.nl> <AF0417C8-B129-49D8-A813-3618B527B88D@rdsor.ro> <564DD856.6030007@digiware.nl> <78FDD0DE-5CA0-44AB-B46C-9C95E4F8DA5B@rdsor.ro>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 19, 2015 at 8:29 AM, Dan Partelly <dan_partelly@rdsor.ro> wrote= : >> Unlike what you suggest here, I see lots of issues in Bugzilla which >> exactly what you describe: enhancements on already available tools. >> I've even submitted a few myself. > > Thats great Willem. > > But no matter what you find odd or not, I am simply following what Ive re= ad on some > page on freebsd.org that one of the ways of contributing is by submitting= code > on the mailing-lists , where =E2=80=9Csomebody will happily pick up chang= es=E2=80=9D. > > So, if you continue to find this odd, please take it up with the web-mast= ers on > freebsd.org to update the resources regarding contributing to the project= . Dan, I think a lot of people tend to use the 'one-two punch' of both PR and mailing list. Mailing list to flesh it out and discuss the idea, and the PR when it's ready to go in. I've done a very cursory review of your patch, and it looks pretty good. Unfortunately, my time is booked for more projects than I really have time for, so I'd be unable to test it. If you submit it as a PR in bugzilla, at the very least the patch won't get lost when someone else comes looking for the feature, and more likely it'll get picked up by someone rather quickly or in the next triage phase (some people like to do bug triaging periodically, where things like this get their basic testing and commit). When you said it's not a patch for an issue/bug/etc, one could say the bug is that the patch isn't already in the tree :) . - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHSQbTD7B_U78y8xWed%2BeEwqQ9A3Y2ZMP_=VfzY2N9eaL6G5_A>