Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 15 Jan 2000 01:14:09 +1100 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Jason Evans <jasone@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern init_sysent.c sys_generic.c syscalls.c syscalls.master uipc_socket.c uipc_socket2.c vfs_aio.c src/sys/sys aio.h socketvar.h syscall-hide.h syscall.h syscall.mk sysproto.h
Message-ID:  <Pine.BSF.4.10.10001150101530.6969-100000@alphplex.bde.org>
In-Reply-To: <200001140253.SAA53905@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 13 Jan 2000, Jason Evans wrote:

> jasone      2000/01/13 18:53:30 PST
> 
>   Modified files:
>     sys/kern             init_sysent.c sys_generic.c syscalls.c 
>                          syscalls.master uipc_socket.c 
>                          uipc_socket2.c vfs_aio.c 
>     sys/sys              aio.h socketvar.h syscall-hide.h 
>                          syscall.h syscall.mk sysproto.h 
>   Log:
>   Add aio_waitcomplete().  Make aio work correctly for socket descriptors.
>   Make gratuitous style(9) fixes (me, not the submitter) to make the aio
>   code more readable.
>   
>   PR:		kern/12053
>   Submitted by:	Chris Sedore <cmsedore@maxwell.syr.edu>
>   
>   Revision  Changes    Path
>   ...
>   1.65      +634 -503  src/sys/kern/vfs_aio.c

Don't mix style fixes with new functionality.  It makes the diffs hard to
read, and hides the new bugs.  This change is a particularly good bad
example.  It reformats lots of old code.  The diff (-c1) is 25% larger
than the original file.

Bruce



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.10001150101530.6969-100000>