From owner-cvs-all Fri Jan 14 6:14:28 2000 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 2B99D15205; Fri, 14 Jan 2000 06:14:16 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (beefcake.zeta.org.au [203.26.10.12]) by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id BAA32154; Sat, 15 Jan 2000 01:14:12 +1100 Date: Sat, 15 Jan 2000 01:14:09 +1100 (EST) From: Bruce Evans X-Sender: bde@alphplex.bde.org To: Jason Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_sysent.c sys_generic.c syscalls.c syscalls.master uipc_socket.c uipc_socket2.c vfs_aio.c src/sys/sys aio.h socketvar.h syscall-hide.h syscall.h syscall.mk sysproto.h In-Reply-To: <200001140253.SAA53905@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Thu, 13 Jan 2000, Jason Evans wrote: > jasone 2000/01/13 18:53:30 PST > > Modified files: > sys/kern init_sysent.c sys_generic.c syscalls.c > syscalls.master uipc_socket.c > uipc_socket2.c vfs_aio.c > sys/sys aio.h socketvar.h syscall-hide.h > syscall.h syscall.mk sysproto.h > Log: > Add aio_waitcomplete(). Make aio work correctly for socket descriptors. > Make gratuitous style(9) fixes (me, not the submitter) to make the aio > code more readable. > > PR: kern/12053 > Submitted by: Chris Sedore > > Revision Changes Path > ... > 1.65 +634 -503 src/sys/kern/vfs_aio.c Don't mix style fixes with new functionality. It makes the diffs hard to read, and hides the new bugs. This change is a particularly good bad example. It reformats lots of old code. The diff (-c1) is 25% larger than the original file. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message