Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 04 Apr 2016 06:05:15 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 208497] less in 10.3-RELEASE in more compatibility mode cause freebsd-update to page when it shouldn't
Message-ID:  <bug-208497-8-4F2cnSpVzH@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-208497-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-208497-8@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D208497

dereks@lifeofadishwasher.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.greenwoodsoftwar
                   |                            |e.com/less/news.481.html

--- Comment #1 from dereks@lifeofadishwasher.com ---
less's update to 481 in 10.3-RELEASE causes more compatibility more to page
output when you reach EOF:

 ...
 - In more-compatible mode, change the -e option to work like -E, not -EF.=
=20
 ...

This didn't happen in <10.3 running freebsd-update without when nothing was=
 to
be updated.

less when ran in more compatibility without -e applies as if -e was used.

freebsd-update sends all output to a $PAGER (by default - more) by piping a=
 sh
if to $PAGER:

  if
    ....
  fi | $PAGER

I don't think less should change for this (or if it's even a bug in less).

Should freebsd-update to not pipe if's contents but rather a grouped { ... =
; }
output inside the if block:

  ...
  # Report to the user if any updates were avoided due to local changes
  if [ -s modifiedfiles ]; then
    { echo
    echo -n "The following files are affected by updates, "
    echo "but no changes have"=20
    echo -n "been downloaded because the files have been "
    echo "modified locally:"
    cat modifiedfiles; } | $PAGER
  fi
  ...

I believe that's the way PAGER is used in all of freebsd-update.
If so should the attached patch fix this?

PS: I hit return in the subject when I first reported this bug hence the em=
pty
comment.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-208497-8-4F2cnSpVzH>