From owner-cvs-all@FreeBSD.ORG Wed Apr 14 06:19:05 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9105316A4CE; Wed, 14 Apr 2004 06:19:05 -0700 (PDT) Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 241D643D58; Wed, 14 Apr 2004 06:19:05 -0700 (PDT) (envelope-from danfe@regency.nsu.ru) Received: from regency.nsu.ru ([193.124.210.26]) by mx.nsu.ru with esmtp (Exim 4.30) id 1BDkL8-0005IC-FR; Wed, 14 Apr 2004 20:22:06 +0700 Received: from regency.nsu.ru (localhost [127.0.0.1]) by regency.nsu.ru (8.12.10/8.12.10) with ESMTP id i3EDJRGt068316; Wed, 14 Apr 2004 20:19:27 +0700 (NOVST) (envelope-from danfe@regency.nsu.ru) Received: (from danfe@localhost) by regency.nsu.ru (8.12.10/8.12.10/Submit) id i3EDJQLR068242; Wed, 14 Apr 2004 20:19:26 +0700 (NOVST) (envelope-from danfe) Date: Wed, 14 Apr 2004 20:19:26 +0700 From: Alexey Dokuchaev To: Dag-Erling Sm?rgrav Message-ID: <20040414131926.GA67192@regency.nsu.ru> References: <200404140040.i3E0esil061104@repoman.freebsd.org> <20040414021526.GB63832@elvis.mu.org> <20040414093706.GB65853@regency.nsu.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i cc: cvs-src@freebsd.org cc: Tim Kientzle cc: Alfred Perlstein cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar bsdtar.c bsdtar.h write.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2004 13:19:05 -0000 On Wed, Apr 14, 2004 at 02:11:30PM +0200, Dag-Erling Sm?rgrav wrote: > Alexey Dokuchaev writes: > > On Tue, Apr 13, 2004 at 07:15:26PM -0700, Alfred Perlstein wrote: > > > While I applaud the effort here, it is a major violation of C > > > POLA to have compilable code within a header file. > > Seconded. Please keep *.h code-free. > > What are you guys all smoking? Did you even look at the file in > question? Nope; sorry for the noise. I blindly believed that Alfred did though. Won't hesitate to _read_ the actual diffs next time. Thanks. ./danfe