Date: Sun, 31 Oct 2004 11:01:14 +0100 (CET) From: Tobias Roth <ports@fsck.ch> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/73338: [patch] unbreak x11/login.app Message-ID: <200410311001.i9VA1E7c083807@secure.socket.ch> Resent-Message-ID: <200410311010.i9VAAU3u040147@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 73338 >Category: ports >Synopsis: [patch] unbreak x11/login.app >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Oct 31 10:10:30 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Tobias Roth >Release: FreeBSD 5.3-BETA7 i386 >Organization: >Environment: System: FreeBSD localhost 5.3-BETA7 FreeBSD 5.3-BETA7 #2: Wed Oct 13 08:25:14 CEST 2004 toor@localhost:/opt/obj/usr/src/sys/FOOBAR i386 >Description: This patch unbreaks x11/login.app. It substitutes a deprecated function that has been removed with the latest windowmaker update. Two files are added: files/patch-graphics.c files/patch-panel.c I intend to take maintainership and upgrade the port to the latest version later on. >How-To-Repeat: Build current x11/login.app from ports with all its latest deps. You'll see a linker error. >Fix: diff -ruN login.app.orig/files/patch-graphics.c login.app/files/patch-graphics.c --- login.app.orig/files/patch-graphics.c Thu Jan 1 01:00:00 1970 +++ login.app/files/patch-graphics.c Sun Oct 31 11:46:03 2004 @@ -0,0 +1,11 @@ +--- graphics.c.orig Sun Oct 31 11:44:10 2004 ++++ graphics.c Sun Oct 31 11:44:54 2004 +@@ -73,7 +73,7 @@ + img = RCloneImage(bottom); + RCombineImages(img, top); + setWindowImage(win, img); +- RDestroyImage(img); ++ RReleaseImage(img); + } + + void drawText(Window win, XFontStruct* font, int justification, int x, int y, diff -ruN login.app.orig/files/patch-panel.c login.app/files/patch-panel.c --- login.app.orig/files/patch-panel.c Thu Jan 1 01:00:00 1970 +++ login.app/files/patch-panel.c Sun Oct 31 11:46:18 2004 @@ -0,0 +1,11 @@ +--- panel.c.orig Sun Oct 31 11:44:16 2004 ++++ panel.c Sun Oct 31 11:44:41 2004 +@@ -297,7 +297,7 @@ + + image = RCreateImageFromDrawable(ctx, panel, 0); + RConvertImage(ctx, image, &shrinkPixmap); +- RDestroyImage(image); ++ RReleaseImage(image); + + XSetWindowBackgroundPixmap(dpy, panel, shrinkPixmap); + XUnmapSubwindows(dpy, panel); >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200410311001.i9VA1E7c083807>