Date: Thu, 29 Jan 2009 22:34:22 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Edward Tomasz Napierala <trasz@freebsd.org> Subject: Re: svn commit: r187894 - head/sys/ufs/ffs Message-ID: <20090129203422.GA1906@deviant.kiev.zoral.com.ua> In-Reply-To: <200901291343.55485.jhb@freebsd.org> References: <200901291647.n0TGlFHZ058776@svn.freebsd.org> <200901291209.14313.jhb@freebsd.org> <20090129181523.GA2471@deviant.kiev.zoral.com.ua> <200901291343.55485.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 29, 2009 at 01:43:54PM -0500, John Baldwin wrote: > On Thursday 29 January 2009 1:15:23 pm Kostik Belousov wrote: > > On Thu, Jan 29, 2009 at 12:09:13PM -0500, John Baldwin wrote: > > > On Thursday 29 January 2009 11:47:15 am Edward Tomasz Napierala wrote: > > > > Author: trasz > > > > Date: Thu Jan 29 16:47:15 2009 > > > > New Revision: 187894 > > > > URL: http://svn.freebsd.org/changeset/base/187894 > > > >=20 > > > > Log: > > > > Make sure the cdev doesn't go away while the filesystem is still= =20 > mounted. > > > > Otherwise dev2udev() could return garbage. > > > > =20 > > > > Reviewed by: kib > > > > Approved by: rwatson (mentor) > > > > Sponsored by: FreeBSD Foundation > > >=20 > > > Is this applicable to all filesystems? I'm curious why the VREF() on= the=20 > > > vnode associated with the cdev entry (um_devvp) is not sufficient to= =20 > prevent=20 > > > this? I would have thought that the vnode would have held a referenc= e on=20 > the=20 > > > cdev. > >=20 > > The point of this commit is that devvp vnode may be reclaimed. >=20 > So do all filesystems need this change then? I briefly looked over cd9660. It caches the cdev in the im_dev member of its mount structure, that is consequently used as an argument to dev2udev() in cd9660_getattr(). I think that typical answer to your question is "yes". --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkmCEswACgkQC3+MBN1Mb4jHbACfWS/CFL1Rz/J4Jz8L6vHmVYy+ QlcAoMN5Dq5qy/pxXxzlBLwhLXRSw0rL =1MuM -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090129203422.GA1906>