Date: Tue, 20 Mar 2018 18:51:40 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Warner Losh <imp@bsdimp.com> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331269 - head/share/man/man9 Message-ID: <201803210151.w2L1pelA019277@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CANCZdfrRWcAt70KgQFwQEHuBHY=mPEiDVwofn3zACGhVFT-Nsw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> > On Mar 20, 2018 6:57 PM, "Rodney W. Grimes" <freebsd@pdx.rh.cn85.dnsmgr.net> > > wrote: > > > > > Author: imp > > > Date: Tue Mar 20 21:37:33 2018 > > > New Revision: 331269 > > > URL: https://svnweb.freebsd.org/changeset/base/331269 > > > > > > Log: > > > Remove reference to lint. We no longer support it, so exceptions for > > > it are no longer relevant. > > > > I still believe this is putting the cart before the horse: > > /usr/src # find . -print0 | xargs -0 grep "ifndef lint" | wc > > 1228 2459 48568 > > > > Perhaps yes, perhaps no. They are slowly being eliminated and no new lint > code. It's time. You will find that there is much of this in contrib, so it will not be so easy to eliminate. And again, your email client is not quoting properly, I have re-quoted it. > Warner > > > Modified: > > head/share/man/man9/style.9 > > > > Modified: head/share/man/man9/style.9 > > ============================================================ > ================== > > --- head/share/man/man9/style.9 Tue Mar 20 21:36:35 2018 > (r331268) > > +++ head/share/man/man9/style.9 Tue Mar 20 21:37:33 2018 > (r331269) > > @@ -107,11 +107,7 @@ Only add > > .Dq Li "From: " > > in front of foreign VCS IDs if the file is renamed. > > .Bd -literal > > -#if 0 > > -#ifndef lint > > -static char sccsid[] = "@(#)style 1.14 (Berkeley) 4/28/95"; > > -#endif /* not lint */ > > -#endif > > +/* From: @(#)style 1.14 (Berkeley) 4/28/95 */ > > > > #include <sys/cdefs.h> > > __FBSDID("$FreeBSD$"); > > @@ -234,10 +230,6 @@ This comment should be used only for (subjectively) > lo > > greater than 20 lines, or where a series of nested > > .Ic #ifdef 's > > may be confusing to the reader. > > -Exceptions may be made for cases where code is conditionally not > compiled for > > -the purposes of > > -.Xr lint 1 , > > -even though the uncompiled region may be small. > > The comment should be separated from the > > .Ic #endif > > or > > > > > > -- > Rod Grimes > rgrimes@freebsd.org -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201803210151.w2L1pelA019277>