Date: Fri, 7 Apr 2017 11:02:06 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: Xin LI <delphij@gmail.com> Cc: "David E. O'Brien" <obrien@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r316591 - head/sys/dev/tpm Message-ID: <96F125AA-29BF-4CB5-9713-A398F650CBF2@gmail.com> In-Reply-To: <39DE48A2-9526-497E-B178-CE78B2EF4020@gmail.com> References: <201704062221.v36MLnr7092648@repo.freebsd.org> <F4902DBF-9E62-4ED0-8960-851E43F4F745@gmail.com> <CAGMYy3uDMcTQw_MqquXGxfPWcWFF9FikTA4LWwK4jmsvgjza1Q@mail.gmail.com> <39DE48A2-9526-497E-B178-CE78B2EF4020@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 7, 2017, at 10:59, Ngie Cooper <yaneurabeya@gmail.com> wrote: >=20 >=20 >> On Apr 7, 2017, at 10:17, Xin LI <delphij@gmail.com> wrote: >>=20 >> No, David's change was correct. >>=20 >> The code context is something like: >>=20 >> #ifdef __FreeBSD__ >> [...] >> #else /* OpenBSD */ >> ... >> #ifdef __FreeBSD__ /* -- this portion got removed -- */ >> ... >> #else >> ... >> #endif >> [...] >> #endif >=20 > So, in short David enabled suspend/resume support in tpm(4)... (it looks l= ike it was disabled before, just based on the variable names/calls)? Why was= n't that clearly stated in the commit? Bah. I missed the nested FreeBSD in OpenBSD comment.. nevermind the part abo= ut enabling power support. It's too early for me to be thinking critically I= guess..=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?96F125AA-29BF-4CB5-9713-A398F650CBF2>